fix(inheritance-report): adding funeral service cost #17159
Conversation
WalkthroughThe pull request introduces several modifications to enhance the handling of funeral costs within the inheritance report. Key changes include the addition of a Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17159 +/- ##
==========================================
- Coverage 35.73% 35.73% -0.01%
==========================================
Files 6926 6926
Lines 147677 147678 +1
Branches 42062 42062
==========================================
Hits 52775 52775
- Misses 94902 94903 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
libs/application/templates/inheritance-report/src/fields/FuneralCost/index.tsx (1)
Line range hint
79-90: LGTM! Consider grouping related costsThe addition of
servicesCostis implemented correctly, following the established pattern. However, consider grouping related costs together for better maintainability.Consider grouping the costs by category:
const buildCost = valueToNumber(values?.build) const cremationCost = valueToNumber(values?.cremation) + const servicesCost = valueToNumber(values?.service) const printCost = valueToNumber(values?.print) const flowersCost = valueToNumber(values?.flowers) const musicCost = valueToNumber(values?.music) const rentCost = valueToNumber(values?.rent) const foodCost = valueToNumber(values?.food) const tombstoneCost = valueToNumber(values?.tombstone) - const servicesCost = valueToNumber(values?.service)libs/application/templates/inheritance-report/src/lib/messages.ts (1)
998-1002: Consider adding a description for the funeralServiceCost messageThe description field is empty. Consider adding a meaningful description to maintain consistency with other messages and help other developers understand the context of this translation key.
funeralServiceCost: { id: 'ir.application:funeralServiceCost', defaultMessage: 'Útfararþjónusta', - description: '', + description: 'Label for funeral service cost field in the funeral costs section', },
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (4)
libs/application/templates/inheritance-report/src/fields/FuneralCost/index.tsx(2 hunks)libs/application/templates/inheritance-report/src/fields/Overview/OverviewDebts/index.tsx(1 hunks)libs/application/templates/inheritance-report/src/forms/sections/debtsAndFuneralCost.ts(1 hunks)libs/application/templates/inheritance-report/src/lib/messages.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
libs/application/templates/inheritance-report/src/fields/Overview/OverviewDebts/index.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/debtsAndFuneralCost.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/FuneralCost/index.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/lib/messages.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (3)
libs/application/templates/inheritance-report/src/fields/Overview/OverviewDebts/index.tsx (1)
97-102: LGTM! Consistent implementation
The new row for funeral service cost is implemented correctly, following the established patterns for internationalization and currency formatting.
libs/application/templates/inheritance-report/src/forms/sections/debtsAndFuneralCost.ts (1)
158-161: LGTM! Verify message definition
The new field for funeral service cost is properly configured. Let's verify that the corresponding message is defined.
✅ Verification successful
Message definition verified successfully
The message key funeralServiceCost is properly defined in the messages file with the appropriate ID structure ir.application:funeralServiceCost.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that the message key exists in the messages file
rg -A 1 "funeralServiceCost.*=.*{" libs/application/templates/inheritance-report/src/lib/messages.ts
Length of output: 214
Script:
#!/bin/bash
# Search for funeralServiceCost in messages file with proper escaping
rg "funeralServiceCost" libs/application/templates/inheritance-report/src/lib/messages.ts
Length of output: 158
libs/application/templates/inheritance-report/src/lib/messages.ts (1)
1261-1261: LGTM: Terminology update for deceased's share
The change from "Hlutfall séreignar" to "Búshluti maka" improves clarity by using consistent terminology for spouse's share throughout the application.
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 4 Passed Test Services
|
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Checklist:
Summary by CodeRabbit
New Features
Updates