fix(inheritance-report): EFS finalizing changes #14867
Conversation
WalkthroughThe changes across various components and files aim to enhance the inheritance report application by integrating funeral costs into total debts calculation, improving error handling, and refining the form structure and user experience. These updates include adding new fields and components, reorganizing sections, and updating messages and types to support the application's enhancements. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14867 +/- ##
==========================================
- Coverage 37.07% 36.96% -0.12%
==========================================
Files 6351 6330 -21
Lines 129276 129104 -172
Branches 36920 36845 -75
==========================================
- Hits 47928 47722 -206
- Misses 81348 81382 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Affected services are: api,application-system-api,application-system-form, |
albinagu
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (8)
- libs/application/templates/inheritance-report/src/fields/CalculationsOfTotal/CalculateTotalDebts/index.tsx (1 hunks)
- libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/index.tsx (2 hunks)
- libs/application/templates/inheritance-report/src/forms/form.ts (2 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/debtsAndFuneralCost.ts (3 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/heirs.ts (2 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/preSelection.ts (1 hunks)
- libs/application/templates/inheritance-report/src/lib/messages.ts (6 hunks)
- libs/application/templates/inheritance-report/src/types.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- libs/application/templates/inheritance-report/src/forms/sections/preSelection.ts
Additional Context Used
GitHub Check Runs (1)
linting (application-system-form,application-template-api-modules,application-template-loader,app... success (20)
libs/application/templates/inheritance-report/src/types.ts: [warning] 225-225:
'DomesticAndForeignDebtsData' is defined but never used. Allowed unused vars must match /^_[a-zA-Z0-9]*$/u
Path-based Instructions (7)
libs/application/templates/inheritance-report/src/fields/CalculationsOfTotal/CalculateTotalDebts/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/form.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/types.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/heirs.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/debtsAndFuneralCost.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (9)
libs/application/templates/inheritance-report/src/forms/form.ts (2)
11-11: Correctly updated import to reflect the new structure of debt and funeral cost handling.
33-33: Proper integration ofdebtsAndFuneralCostinto the form structure.libs/application/templates/inheritance-report/src/types.ts (1)
213-217: UpdatedDebtinterface correctly reflects the new fields required for the application.libs/application/templates/inheritance-report/src/forms/sections/debtsAndFuneralCost.ts (1)
Line range hint
20-400: The restructuring of the debts and funeral cost sections is comprehensive and aligns with the PR objectives. Ensure that all new fields and components are properly tested to verify their functionality.libs/application/templates/inheritance-report/src/fields/HeirsAndPartitionRepeater/index.tsx (1)
123-125: The updated error handling logic in theHeirsAndPartitionRepeatercomponent is correctly implemented. Consider adding more detailed logging for debugging purposes.+ console.log('Error details:', error)Likely invalid or redundant comment.
libs/application/templates/inheritance-report/src/lib/messages.ts (4)
30-35: Ensure consistency in message IDs and descriptions for better maintainability.The addition of a new message key
preDataCollectionChooseEstateSelectTitleDropdownwith a specific description for a dropdown enhances clarity and user experience.
429-429: Verify the usage of the newpropertyNumbermessage key across the application.
942-958: Review the integration of new total amount message keys to ensure they are displayed correctly in the UI.
1510-1510: Validate the new validation message forerrorPropertyNumberto ensure it covers all specified formats.
...on/templates/inheritance-report/src/fields/CalculationsOfTotal/CalculateTotalDebts/index.tsx
Show resolved
Hide resolved
libs/application/templates/inheritance-report/src/forms/sections/heirs.ts
Outdated
Show resolved
Hide resolved
…thub.com/island-is/island.is into efs_debts_and_funeralcost
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- libs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx (3 hunks)
- libs/application/templates/inheritance-report/src/forms/form.ts (2 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/deceased.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- libs/application/templates/inheritance-report/src/forms/form.ts
Additional Context Used
Path-based Instructions (2)
libs/application/templates/inheritance-report/src/forms/sections/deceased.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (1)
libs/application/templates/inheritance-report/src/fields/CalculateShare/index.tsx (1)
498-500: Ensure conditional rendering logic aligns with user expectations.The addition of the conditional rendering based on
deceasedHadAssetsandshareTotalis logical and enhances the UI by preventing the display of irrelevant information. Verify with stakeholders that this behavior matches user expectations.
libs/application/templates/inheritance-report/src/forms/sections/deceased.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (7)
- libs/application/templates/inheritance-report/src/fields/OverviewAssets/rows.ts (1 hunks)
- libs/application/templates/inheritance-report/src/fields/ReportFieldsRepeater/index.tsx (1 hunks)
- libs/application/templates/inheritance-report/src/forms/OverviewSections/OverviewAssets.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/assets.ts (1 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/debtsAndFuneralCost.ts (3 hunks)
- libs/application/templates/inheritance-report/src/forms/sections/heirs.ts (2 hunks)
- libs/application/templates/inheritance-report/src/lib/messages.ts (7 hunks)
Files skipped from review due to trivial changes (2)
- libs/application/templates/inheritance-report/src/forms/OverviewSections/OverviewAssets.ts
- libs/application/templates/inheritance-report/src/forms/sections/assets.ts
Files skipped from review as they are similar to previous changes (2)
- libs/application/templates/inheritance-report/src/forms/sections/heirs.ts
- libs/application/templates/inheritance-report/src/lib/messages.ts
Additional Context Used
Path-based Instructions (3)
libs/application/templates/inheritance-report/src/fields/OverviewAssets/rows.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/forms/sections/debtsAndFuneralCost.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/fields/ReportFieldsRepeater/index.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (4)
libs/application/templates/inheritance-report/src/fields/OverviewAssets/rows.ts (1)
92-92: Updated title for gun serial number to use localized message. This is a good practice for supporting multiple languages.libs/application/templates/inheritance-report/src/forms/sections/debtsAndFuneralCost.ts (2)
20-105: Structured addition of new fields and components in thedebtsAndFuneralCostsection enhances form functionality and user experience. Good use of modular components.
Line range hint
175-413: Addition of thedebtsAndFuneralCostOverviewsection effectively presents calculated totals using custom fields and key-value pairs. Well-implemented data presentation.libs/application/templates/inheritance-report/src/fields/ReportFieldsRepeater/index.tsx (1)
355-359: Improved handling ofassetNumberfield for bank accounts with specific formatting and placeholder text enhances user input accuracy and experience.
albinagu
added
automerge
Feature branch: https://efsdebtsandfuneralcost-beta.dev01.devland.is/umsoknir/erfdafjarskyrsla
Checklist:
Summary by CodeRabbit
New Features
CalculateSharecomponent for more streamlined display.funeralCostcalculation to theCalculateTotalDebtscomponent.Bug Fixes
HeirsAndPartitionRepeatercomponent.Enhancements
Refactor