Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inheritance-report): adding service to mappers #17177

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

albinagu
Copy link
Member

@albinagu albinagu commented Dec 9, 2024

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Added a new optional field service to the funeral cost details in the inheritance report, enhancing the data structure.
  • Bug Fixes

    • Updated message identifiers to include a #markdown suffix for better rendering and processing.
    • Modified the description for prepaid heirs in the user interface to reflect updated information.
  • Documentation

    • Changes documented to reflect the new field and updated message identifiers.

@albinagu albinagu requested a review from a team as a code owner December 9, 2024 10:53
Copy link
Contributor

coderabbitai bot commented Dec 9, 2024

Walkthrough

The changes in this pull request involve modifications to the expandAnswers function and the inheritanceReportSchema. A new optional property service is added to the funeralCost object in both the function's return structure and the schema definition. Additionally, several message identifiers in the messages.ts file are updated to include a #markdown suffix, reflecting a change in how these messages may be processed. No existing properties or validation logic were altered.

Changes

File Change Summary
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/utils/mappers.ts Added service property to funeralCost object in the return type of expandAnswers function.
libs/application/templates/inheritance-report/src/lib/dataSchema.ts Introduced optional service: z.string().optional() field in the funeralCost object of the schema.
libs/application/templates/inheritance-report/src/lib/messages.ts Updated message identifiers to include a #markdown suffix for several entries.
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/heirs.ts Changed description property in buildMultiField function to use heirAdditionalInfoPrePaidDescription.

Possibly related PRs

  • fix(inheritance-report): EFS fixes 4.06 #15097: This PR modifies the expandAnswers function in mappers.ts to add a new field applicationFor, which is related to the changes made in the main PR that also modifies the expandAnswers function to include a new property service in the funeralCost object.
  • fix(inheritance-report): Prepaid finishups #15323: This PR adds additional fields to the expandAnswers function, which is directly related to the changes in the main PR that also focuses on modifications to the expandAnswers function.
  • fix(inheritance-report): adding funeral service cost #17159: This PR introduces a new field for funeral service costs in the debtsAndFuneralCost section, which is directly related to the changes in the main PR that adds a service property to the funeralCost object.

Suggested labels

deploy-feature

Suggested reviewers

  • juni-haukur
  • kksteini

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e189901 and 92523a4.

📒 Files selected for processing (2)
  • libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/heirs.ts (1 hunks)
  • libs/application/templates/inheritance-report/src/lib/messages.ts (3 hunks)
👮 Files not reviewed due to content moderation or server errors (2)
  • libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/heirs.ts
  • libs/application/templates/inheritance-report/src/lib/messages.ts
🧰 Additional context used
📓 Path-based instructions (2)
libs/application/templates/inheritance-report/src/forms/sections/prepaidInheritance/heirs.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

  • Reusability of components and hooks across different NextJS apps.
  • TypeScript usage for defining props and exporting types.
  • Effective tree-shaking and bundling practices."
libs/application/templates/inheritance-report/src/lib/messages.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

  • Reusability of components and hooks across different NextJS apps.
  • TypeScript usage for defining props and exporting types.
  • Effective tree-shaking and bundling practices."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.73%. Comparing base (fb234b4) to head (92523a4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ules/templates/inheritance-report/utils/mappers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17177   +/-   ##
=======================================
  Coverage   35.73%   35.73%           
=======================================
  Files        6926     6926           
  Lines      147699   147692    -7     
  Branches    42073    42068    -5     
=======================================
  Hits        52776    52776           
+ Misses      94923    94916    -7     
Flag Coverage Δ
api 3.33% <ø> (ø)
api-domains-auth-admin 48.49% <ø> (ø)
api-domains-communications 39.45% <ø> (ø)
application-system-api 38.76% <0.00%> (+<0.01%) ⬆️
application-template-api-modules 27.82% <0.00%> (-0.01%) ⬇️
application-templates-inheritance-report 6.54% <ø> (ø)
application-ui-shell 22.46% <ø> (ø)
cms 0.40% <ø> (ø)
cms-translations 38.79% <ø> (ø)
contentful-apps 4.72% <ø> (ø)
judicial-system-api 19.98% <ø> (ø)
judicial-system-backend 55.71% <ø> (-0.02%) ⬇️
services-user-notification 46.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ort/src/forms/sections/prepaidInheritance/heirs.ts 0.00% <ø> (ø)
...templates/inheritance-report/src/lib/dataSchema.ts 0.00% <ø> (ø)
...n/templates/inheritance-report/src/lib/messages.ts 100.00% <ø> (ø)
...ules/templates/inheritance-report/utils/mappers.ts 2.97% <0.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb234b4...92523a4. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Dec 9, 2024

Datadog Report

All test runs bb83865 🔗

11 Total Test Services: 0 Failed, 10 Passed
➡️ Test Sessions change in coverage: 33 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.36s 1 no change Link
api-domains-auth-admin 0 0 0 18 0 10.09s 1 no change Link
api-domains-communications 0 0 0 5 0 29.31s 1 no change Link
api-domains-license-service 0 0 0 0 0 474.63ms 1 no change Link
application-system-api 0 0 0 46 0 2m 22.92s 1 no change Link
application-template-api-modules 0 0 0 118 0 2m 31.92s 1 no change Link
application-ui-shell 0 0 0 74 0 35.35s 1 no change Link
cms-translations 0 0 0 3 0 31.39s 1 no change Link
judicial-system-api 0 0 0 61 0 7.36s 1 no change Link
judicial-system-backend 0 0 0 21252 0 22m 52.85s 1 no change Link

@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Dec 9, 2024
@kodiakhq kodiakhq bot merged commit 31b2fdb into main Dec 9, 2024
66 checks passed
@kodiakhq kodiakhq bot deleted the ir_funeralservice branch December 9, 2024 13:59
thorhildurt pushed a commit that referenced this pull request Dec 11, 2024
* fix(inheritance-report): adding service to mappers

* prepaid text

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants