-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent ionic NgModel components #8578
Comments
I started using abstract classes here for each of our input types, we can use this to come up with a standard. https://github.com/driftyco/ionic/blob/master/src/util/form.ts#L66 |
Ionic inputs should not break if userland code crashes. i.e. we should wrap calls to user's code with try{} catch Pseudocode: dispatchEvent() {
try {
this.userland();
}catch() {
// restore state and rethrow
}
} |
All inputs to implement |
All events in ionic should behave the same: |
ng-valid handling inconsistency: #10952 |
Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. Thank you for using Ionic! |
We should revisit:
and events like
(ionChange)
,(ionSelect)
in across the framework: Tabs, SplitPane, SlidingItem...Each one has a different policy when calling the callbacks.
Examples:
Toggle: https://github.com/driftyco/ionic/blob/master/src/components/toggle/toggle.ts#L230-L246
Range: https://github.com/driftyco/ionic/blob/master/src/components/range/range.ts#L620-L649
I propose to create a new design document to describe how an ionic component should work through a base interface and a standarized behavior, we could even create "base unit tests" shared between all the inputs.
ping
@adamdbradley
@brandyscarney
I think this should be approached before ionic 2.0 final is released. Probably in 2.0rc2
The text was updated successfully, but these errors were encountered: