Added RadioButton to emitted event

[patrickbussmann]

This allows to update the checked state manually via the event process.

Short description of what this resolves:

A problem by manually set the checked state of radio buttons.

The main problem is that I want to uncheck a radio button within a radio-group if its clicked and not required. But currently it stays checked. I want if its not required that its unchecked then like a checkbox. But then I lose the ability to check one radio button at the same time.

Changes proposed in this pull request:

• Added second parameter to event emitter of radio button with this value (first parameter is this.value)

Ionic Version: 1.x / 2.x
2.x

Fixes: #
-/-

[brandyscarney]

I'm sorry I'm not fully understanding what you're trying to do. Could you provide a plunker, repository or images of what you mean? Thanks!

[patrickbussmann]

I want to uncheck a radio button if its checked once. Like a checkbox. An optional radio which must not be set will be reset. Nothing more :-) 2017-03-16 19:20 GMT+01:00 Brandy Carney <[email protected]>:

…

I'm sorry I'm not fully understanding what you're trying to do. Could you provide a plunker, repository or images of what you mean? Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10657 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AO5L_eLnNBJ-9-XdULO6Xe9NF6cBV7bkks5rmX18gaJpZM4MTkla> .

[manucorporat]

@brandyscarney I think this is another case of: #8578

some components do:

    this.ionSelect.emit(this.value);

while others do:

    this.ionSelect.emit(this);

Changing this would be an important breaking change, but I think it worth it... we should always provide this, it is way more powerful.

Then, developers could read the values thought the value property.

[manucorporat]

I don't think we should merge this PR, but we must do something about it.

[patrickbussmann]

Hmm ok. I added this as second parameter to be compatible with previous versions 👍
But if you have other ideas tell us them.

[brandyscarney]

I was thinking the same thing @manucorporat. I've noticed before that we don't always emit this. Need to discuss with @adamdbradley to see if he had a reason for it, but otherwise I'm all for it.

[Ionitron]

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!