refactor(all): consistent inputs #10898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
force-pushed
the
refactor-inputs
branch
from
71ce2f5 to
98e9d24
Compare
manucorporat
force-pushed
the
refactor-inputs
branch
from
7b38b1a to
3d569eb
Compare
manucorporat
commented
Mar 29, 2017
| @@ -58,13 +58,13 @@ export class PageOne { | |||
| buttons: [ | |||
| { | |||
| text: 'Cancel', | |||
| handler: (data: any) => { | |||
| handler: (data) => { | |||
There was a problem hiding this comment.
This is not longer needed, because I added proper types in AlertButton
| '<div class="checkbox-inner"></div>' + | ||
| '</div>' + | ||
| '<button role="checkbox" ' + | ||
| 'type="button" ' + | ||
| 'ion-button="item-cover" ' + | ||
| '[id]="id" ' + | ||
| '[attr.aria-checked]="_checked" ' + | ||
| '[attr.aria-checked]="_value" ' + |
There was a problem hiding this comment.
is _checked is not longer the source of trust, but _value from BaseInput
| */ | ||
| writeValue(val: any) { | ||
| this._setChecked(isTrueProperty(val)); | ||
| this.value = val; |
There was a problem hiding this comment.
back-compatible property
manucorporat
commented
Mar 29, 2017
| } | ||
|
|
||
| if (isTrueProperty(this._disabled)) { | ||
| button._setElementClass('segment-button-disabled', this._disabled); |
There was a problem hiding this comment.
this was not properly refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8578