-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ionDragEnd output event to be emitted on leave for ion-range #10761
Added ionDragEnd output event to be emitted on leave for ion-range #10761
Conversation
Maybe |
@manucorporat Thanks, that is indeed a better name. Changed |
@AmitMY thanks! btw I can change the commit title, but please review the commit message style next time you submit a PR. |
@manucorporat My apologies. Definitely will do next time. |
@AmitMY you are going to kill me hahah Eventually we should implement this events in all the ionic inputs consistently: #8578 Can you modify the PR again using ionFocus = ionDragStart We don't like ionDragEnd because it is not agnostic and there is not Thanks again for your time! |
I'll be happy to change even 10 times if this gets merged :) About dragStart - you supplied all of the methods:
Its just a matter of emitting blur and focus. Done Any way this can be in 2.3 or no way? Edit: |
sure, I expect to merge this today if all the requested changes are added!! |
@@ -360,6 +365,9 @@ export class Range extends Ion implements AfterViewInit, ControlValueAccessor, O | |||
return false; | |||
} | |||
|
|||
// trigger ionFocus event | |||
this.ionFocus.emit(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move this at the bottom of the function just to make sure we don't break anything!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be more correct there, as if I put this at the end, the order of firing would be:
ionChange
-> ionFocus
-> ionChange
x many -> ionBlur
Instead of:
ionFocus
-> ionChange
x (many+1) -> ionBlur
Still think I should change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shit! you right
@AmitMY don't worry about the commit style guide in this PR! |
@AmitMY merged! thanks a lot for the PR! |
Short description of what this resolves:
Currently, there is no way to know if
ionic-range
is being focused or not.Changes proposed in this pull request:
ionDragEnd
toion-range
, that is being triggered when the range is being left (pointer up)<ion-range (ionDragEnd)="onDragEnd($event)"></ion-range>
Ionic Version: 2.2.0
Fixes: This feature request: #10760