-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): login & sign-up page for IDPE #17049
Conversation
Once this feature gets merged, we can start the process of rolling out the new config variables: |
rgba(191, 47, 229, 0.4) 100% | ||
) !important; | ||
background-color: #13002d !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth doing div.clockface--app-wrapper
, may not be possible if more than divs are used
email: string | ||
passwordValidation: FormFieldValidation | ||
password: string | ||
handleInputChange: (e: ChangeEvent<HTMLInputElement>) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
event instead of e
handleInputChange, | ||
handleForgotPasswordClick, | ||
}) => { | ||
const [visible, toggleIcon] = useState(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change visible
to isVisible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change toggleIcon
to toggleVisibility
size={ComponentSize.Large} | ||
status={ | ||
emailValidation.isValid | ||
? ComponentStatus.Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch the logic so that isValid
displays the status when the email
isValid
lastNameValidation: FormFieldValidation | ||
password: string | ||
passwordValidation: FormFieldValidation | ||
handleInputChange: (e: ChangeEvent<HTMLInputElement>) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
passwordValidation, | ||
handleInputChange, | ||
}) => { | ||
const [visible, toggleIcon] = useState(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
]} | ||
leave={{height: 0}} | ||
> | ||
{show => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see below
errors.confirmPasswordError = confirmPasswordError | ||
} | ||
|
||
const isValid = !Object.values(errors).some(error => !!error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change some
to every
to check for an empty string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change isValid
to actually mean that there are no errors, right now it's indicating that there are errors
this.setState({buttonStatus: ComponentStatus.Default}) | ||
return | ||
} | ||
// log the user into Quartz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
login to auth0, not Quartz
} | ||
|
||
private displayErrorMessage = (errors, auth0Err) => { | ||
if (auth0Err.code.includes('error in email')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch this back to regex
from Quartz
} | ||
} | ||
|
||
private handleInputChange = (e: ChangeEvent<HTMLInputElement>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change e
to event
} | ||
|
||
private displayErrorMessage = (errors, auth0Err) => { | ||
if (/error in email/.test(auth0Err.code)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! way to dig deep on this last (exhausting) push over the finish line
#16979) feat(ui): added route logic and basic login page format for login epic
feat(ui): added auth0 to branch and added form functionality
feat(ui): added social button component
refactored the logout component and added in logout functionality behind a feature flag
This PR is the final part in a series of PRs geared at integrating a new sign-up/ log-in flow for cloud users. The view of this page is supposed to mirror the refactored version that exists as a branch on Quartz (and will eventually become the main log-in & sign-up page for Cloud2). This PR was broken down into a separate branch and worked upon in the following PRs:
Add routing logic (feat(ui): added route logic and basic login page format for login epic #16979)
Added Auth0 and Basic form functionality (feat(ui): added auth0 to branch and added form functionality #16987)
Created a Social Button component for sign-in through social identity provider (feat(ui): added social button component #17033)
Added
react-spring
for transition effects between form toggles (feat(ui): added transition effects between form toggling #17044)Added logout functionality (feat(ui): added logout functionality to epic #17045)
CHANGELOG.md updated with a link to the PR (not the Issue)