feat(ui): added transition effects between form toggling #17044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious to see what this looks like. Would it be possible to include here a gif of the toggle happening? |
|
Approved. Missed the click, but this is approved. |
|
Ya, I'm a fool and saw approved on a different PR that I forgot was up - saw this was ready to merge and merged it in |
asalem1
added a commit
that referenced
this pull request
Feb 28, 2020
1 task
asalem1
added a commit
that referenced
this pull request
Mar 6, 2020
asalem1
added a commit
that referenced
this pull request
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a larger PR to add the sign-in functionality to IDPE. This particular PR is intended to add transitioning effects when users toggle between the sign-up and log-in form so that the transition is a bit smoother. Added react-spring as a dependency to keep with existing transition libraries that are used