feat(ui): added social button component #17033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdelambre
reviewed
Feb 27, 2020
| <svg className={`google-logo ${className}`} x="0" y="0" viewBox="0 0 17.6 18"> | ||
| <path | ||
| d="M15 15.8h-3v-2.3c1-.6 1.6-1.6 1.8-2.7H9V7.4h8.5c.1.6.2 1.2.2 1.8-.1 2.7-1 5.1-2.7 6.6z" | ||
| className="google-blue" |
There was a problem hiding this comment.
not sure, but @alexpaxton might have some opinions on using BEM style naming here (class should represent the structure, so like: google-logo--blue-thing)
drdelambre
reviewed
Feb 28, 2020
| } | ||
|
|
||
| export const GithubLogo: FC<Props> = ({className}) => ( | ||
| <svg className={`github-logo ${className}`} role="img" viewBox="0 0 24 24"> |
There was a problem hiding this comment.
use the classer function we use elsewhere for joining classes
drdelambre
approved these changes
Feb 28, 2020
asalem1
added a commit
that referenced
this pull request
Feb 28, 2020
feat(ui): added social button component
1 task
asalem1
added a commit
that referenced
this pull request
Mar 6, 2020
feat(ui): added social button component
asalem1
added a commit
that referenced
this pull request
Mar 9, 2020
feat(ui): added social button component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a styling issue for the social sign-in feature where the social identity buttons didn't have a reference to the logo, and were improperly styled. Created a new shared button component to address this issue, and imported the specific social identity provider SVGs