feat(ui): added logout functionality to epic #17045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCL735
approved these changes
Feb 28, 2020
TCL735
approved these changes
Feb 28, 2020
TCL735
reviewed
Feb 28, 2020
|
|
||
| useEffect(() => { | ||
| handleSignOut() | ||
| }, []) |
drdelambre
reviewed
Feb 28, 2020
| // Utils | ||
| import {isFlagEnabled} from 'src/shared/utils/featureFlag' | ||
|
|
||
| const Logout: FC<WithRouterProps> = ({router}) => { |
There was a problem hiding this comment.
you need some more types in here. try running this in influxdb/ui:
yarn tsc -noImplicitAny | grep -A 3 -i "$(git diff --name-status master | awk '{ print substr($2,4) }')
drdelambre
reviewed
Feb 28, 2020
ui/src/authorizations/apis/index.ts
Outdated
|
|
||
| export const getAuth0Config = async (): Promise<Auth0Config> => { | ||
| try { | ||
| const {data} = await AJAX({ |
There was a problem hiding this comment.
why are you doubling down on using the old request library for new features?
There was a problem hiding this comment.
That's a great question. I did a global search of influxdb for /api/v2private and followed that convention since we aren't actually generating a route for this particular endpoint on IDPE
There was a problem hiding this comment.
use fetch then to keep consistency with oats
drdelambre
reviewed
Feb 28, 2020
| @@ -76,6 +71,16 @@ class LoginPageContents extends PureComponent<DispatchProps> { | |||
| confirmPasswordError: '', | |||
| } | |||
|
|
|||
| public async componentDidMount() { | |||
| const config = await getAuth0Config() | |||
| this.auth0 = auth0js.WebAuth({ | |||
1 task
asalem1
added a commit
that referenced
this pull request
Mar 6, 2020
refactored the logout component and added in logout functionality behind a feature flag
asalem1
added a commit
that referenced
this pull request
Mar 9, 2020
refactored the logout component and added in logout functionality behind a feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR part of a larger PR that is intended to add sign-in functionality to IDPE. This particular PR deals specifically with logging out and allowing users to logout using the existing logout button