Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document navigation options not visible to manager when viewing other users document #4048

Closed
reckart opened this issue Jun 1, 2023 · 0 comments
Closed

Document navigation options not visible to manager when viewing other users document #4048

reckart opened this issue Jun 1, 2023 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Annotation
Milestone
28.2

Comments

@reckart
Copy link
Member

reckart commented Jun 1, 2023

Describe the bug
If a manager is viewing a document, they should always be able to navigate between documents and to export - even if those options are disabled for annotators. This works as long as the manager is viewing their own data, but no longer when viewing data from another user or from the curation user.

To Reproduce
Steps to reproduce the behavior:

  1. Disable option to export documents in the project settings
  2. Disable option to navigate between documents in project settings.
  3. Open a document as a manager user
  4. Switch to sidebar curation mode or view a document of another user
  5. Observer that document navigation actions are missing from action bar

Expected behavior
Document navigation and export options should always be available to managers.

Please complete the following information:

  • Version and build ID: 28.1
@reckart reckart added 🐛Bug Something isn't working Module: Annotation labels Jun 1, 2023
@reckart reckart added this to the 28.2 milestone Jun 1, 2023
@reckart reckart self-assigned this Jun 1, 2023
reckart added a commit that referenced this issue Jun 1, 2023
@reckart
#4048 - Document navigation options not visible to manager when viewi…
b8b0c9a 
…ng other users document

- Centralize permission check for exporting documents into DocumentAccess class
- Permission check for exporting should consider the session owner, not the document owner
reckart added a commit that referenced this issue Jun 1, 2023
@reckart
#4048 - Document navigation options not visible to manager when viewi…
479a617 
…ng other users document

- Centralize permission check for exporting documents into DocumentAccess class
- Permission check for exporting should consider the session owner, not the document owner
reckart added a commit that referenced this issue Jun 1, 2023
@reckart
Merge pull request #4049 from inception-project/bugfix/4048-Document-…
3b163ea 
…navigation-options-not-visible-to-manager-when-viewing-other-users-document

#4048 - Document navigation options not visible to manager when viewing other users document
@reckart reckart closed this as completed Jun 1, 2023
reckart added a commit that referenced this issue Jun 2, 2023
@reckart
Merge branch 'release/28.x'
1f511d8 
* release/28.x:
  #4048 - Document navigation options not visible to manager when viewing other users document
reckart added a commit that referenced this issue Jun 13, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
14d38be 
* main: (189 commits)
  No issue. Minor additions to BioC format description
  #4062 - ViewportTracker should focus on block-like elements
  #4032 - Allow using externalized strings from backend code
  #4060 - Clean up redundant code in annotation handlers
  #4026: Support for error tracking with Sentry
  #3673 - Update dependencies
  update dead link to the new file
  #4055 - Editor scrolls up when left sidebar is opened/closed
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-28.2
  #4052 - Admins no longer see all projects in the project overview
  #3673 - Update dependencies
  #4048 - Document navigation options not visible to manager when viewing other users document
  #3673 - Update dependencies
  #3673 - Update dependencies
  #1496 - Some spans are missing begin offset field
  #1511 - External recommender fails when CAS contains control characters
  #1496 - Some spans are missing begin offset field
  #4040 - Ability to store preferences from client-side code
  #1066 - Recommender status info
  ...

% Conflicts:
%	inception/inception-api-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/annotation/page/AnnotationPageBase.java
%	inception/inception-brat-editor/src/main/java/de/tudarmstadt/ukp/clarin/webanno/brat/annotation/BratAnnotationEditor.java
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController.java
%	inception/inception-documents/src/test/java/de/tudarmstadt/ukp/inception/documents/DocumentServiceImplConcurrencyTest.java
%	inception/inception-external-search-solr/pom.xml
%	inception/inception-html-editor/src/main/java/de/tudarmstadt/ukp/inception/htmleditor/docview/HtmlDocumentViewControllerImpl.java
%	inception/inception-html-editor/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
%	inception/inception-preferences/src/main/java/de/tudarmstadt/ukp/inception/preferences/config/PreferencesServiceAutoConfig.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/LearningRecordServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/TrainingTask.java
%	inception/inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventWebsocketControllerImplTest.java
%	inception/inception-support/pom.xml
%	inception/inception-ui-core/pom.xml
%	inception/inception-websocket/pom.xml
%	inception/pom.xml
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
Archived in project
Milestone
28.2
Development

No branches or pull requests
1 participant
@reckart