Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using externalized strings from backend code #4032

Closed
reckart opened this issue May 29, 2023 · 0 comments
Closed

Allow using externalized strings from backend code #4032

reckart opened this issue May 29, 2023 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request
Milestone
29.0

Comments

@reckart
Copy link
Member

reckart commented May 29, 2023

Is your feature request related to a problem? Please describe.
We can use externalized strings in Wicket components quite well, but when generating messages in backend Spring code, we have no access to it.

Describe the solution you'd like
The wicket-package.properties mechanism should work quite well, but the default PackageStringResourceLoader uses an optionally provided Wicket component to perform the lookup. In backend code, we have no such component. It would seem reasonable to use the caller of some to be defined Strings.getString() method as the context for lookup up a string.
@reckart reckart added the ⭐️ Enhancement New feature or request label May 29, 2023
@reckart reckart added this to the 29.0 milestone May 29, 2023
@reckart reckart self-assigned this May 29, 2023
reckart added a commit that referenced this issue May 29, 2023
@reckart
#4032 - Allow using externalized strings from backend code
336f9a7 
- Add getStrings() mechanism that could be used from backend code
- Bit of cleaning up
- Remove support for `.vue` files which are no longer used by INCEpTION
reckart added a commit that referenced this issue May 29, 2023
@reckart
Merge pull request #4033 from inception-project/feature/4032-Allow-us…
118cb69 
…ing-externalized-strings-from-backend-code

#4032 - Allow using externalized strings from backend code
@reckart reckart closed this as completed May 29, 2023
reckart added a commit that referenced this issue May 29, 2023
@reckart
Merge branch 'main' into refactoring/4030-Move-AnnotatorJS-code-to-di…
777d906 
…fferent-package

* main:
  #4032 - Allow using externalized strings from backend code
reckart added a commit that referenced this issue May 29, 2023
@reckart
#4032 - Allow using externalized strings from backend code
927f15e 
- Use getStrings to fetch name of AnnotatorJS in backend factory class
- Bit of cleaning up
- Remove more support for `.vue` files which are no longer used by INCEpTION
- Remove unused rat-plugin excludes
- Some minor cleaning up
- Document that annotation processing needs to be turned on in Eclipse
reckart added a commit that referenced this issue May 29, 2023
@reckart
Merge pull request #4035 from inception-project/feature/4032-Allow-us…
767018d 
…ing-externalized-strings-from-backend-code

#4032 - Allow using externalized strings from backend code
reckart added a commit that referenced this issue May 29, 2023
@reckart
Merge branch 'main' into refactoring/4034-Remove-deprecated-iframe-ca…
c17ce0c 
…s-html-view

* main:
  #4032 - Allow using externalized strings from backend code
reckart added a commit that referenced this issue May 29, 2023
@reckart
#4032 - Allow using externalized strings from backend code
ccc9cf6 
- Fix recursion
reckart added a commit that referenced this issue Jun 9, 2023
@reckart
#4032 - Allow using externalized strings from backend code
61a63b9 
- Remove props-to-constants-generator annotation processor since it does not work properly in Eclipse (cf. https://stackoverflow.com/a/76356911/2511197)
reckart added a commit that referenced this issue Jun 13, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
14d38be 
* main: (189 commits)
  No issue. Minor additions to BioC format description
  #4062 - ViewportTracker should focus on block-like elements
  #4032 - Allow using externalized strings from backend code
  #4060 - Clean up redundant code in annotation handlers
  #4026: Support for error tracking with Sentry
  #3673 - Update dependencies
  update dead link to the new file
  #4055 - Editor scrolls up when left sidebar is opened/closed
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-28.2
  #4052 - Admins no longer see all projects in the project overview
  #3673 - Update dependencies
  #4048 - Document navigation options not visible to manager when viewing other users document
  #3673 - Update dependencies
  #3673 - Update dependencies
  #1496 - Some spans are missing begin offset field
  #1511 - External recommender fails when CAS contains control characters
  #1496 - Some spans are missing begin offset field
  #4040 - Ability to store preferences from client-side code
  #1066 - Recommender status info
  ...

% Conflicts:
%	inception/inception-api-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/annotation/page/AnnotationPageBase.java
%	inception/inception-brat-editor/src/main/java/de/tudarmstadt/ukp/clarin/webanno/brat/annotation/BratAnnotationEditor.java
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController.java
%	inception/inception-documents/src/test/java/de/tudarmstadt/ukp/inception/documents/DocumentServiceImplConcurrencyTest.java
%	inception/inception-external-search-solr/pom.xml
%	inception/inception-html-editor/src/main/java/de/tudarmstadt/ukp/inception/htmleditor/docview/HtmlDocumentViewControllerImpl.java
%	inception/inception-html-editor/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
%	inception/inception-preferences/src/main/java/de/tudarmstadt/ukp/inception/preferences/config/PreferencesServiceAutoConfig.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/LearningRecordServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/TrainingTask.java
%	inception/inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventWebsocketControllerImplTest.java
%	inception/inception-support/pom.xml
%	inception/inception-ui-core/pom.xml
%	inception/inception-websocket/pom.xml
%	inception/pom.xml
reckart added a commit that referenced this issue Jul 2, 2023
@reckart
Merge branch 'main' into feature/1336-Add-dark-mode
d88b802 
* main:
  No issue. Slightly improving PDF editor visual
  No issue: Experiment with a Jenkinsfile
  No issue: Experiment with a Jenkinsfile
  No issue: Experiment with a Jenkinsfile
  No issue: Experiment with a Jenkinsfile
  No issue: Experiment with a Jenkinsfile
  #4058 - Cannot export texts containing certain characters as UIMA CAS XMI
  #3673 - Update dependencies
  #4066 - Display document name on export failure
  No issue. Minor additions to BioC format description
  #4062 - ViewportTracker should focus on block-like elements
  #4058 - Cannot export texts containing certain characters as UIMA CAS XMI
  #4032 - Allow using externalized strings from backend code
  #4060 - Clean up redundant code in annotation handlers
  #4026: Support for error tracking with Sentry
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request
Projects
Kanban
Archived in project
Milestone
29.0
Development

No branches or pull requests
1 participant
@reckart