Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewportTracker should focus on block-like elements #4062

Closed
reckart opened this issue Jun 10, 2023 · 0 comments
Closed

ViewportTracker should focus on block-like elements #4062

reckart opened this issue Jun 10, 2023 · 0 comments
Assignees
@reckart
Labels
Module: JavaScript Editor API ⚙️ Refactoring
Milestone
28.3

Comments

@reckart
Copy link
Member

reckart commented Jun 10, 2023

Describe the refactoring action
Currently, the ViewportTracker tracks everything that is not somehow inline. It should rather track things that are block-like.

Expected benefit
E.g. math environments should not be tracked directly. Also things where display is none do not need to be tracked - etc.
@reckart reckart added this to the 28.3 milestone Jun 10, 2023
@reckart reckart self-assigned this Jun 10, 2023
reckart added a commit that referenced this issue Jun 10, 2023
@reckart
#4062 - ViewportTracker should focus on block-like elements
1843e5d 
- Change viewport tracking from an exclude list to an include list.
reckart added a commit that referenced this issue Jun 12, 2023
@reckart
Merge pull request #4063 from inception-project/refactoring/4062-View…
02b58fa 
…portTracker-should-focus-on-block-like-elements

#4062 - ViewportTracker should focus on block-like elements
@reckart reckart closed this as completed Jun 12, 2023
reckart added a commit that referenced this issue Jun 13, 2023
@reckart
Merge branch 'release/28.x'
11882d8 
* release/28.x:
  No issue. Minor additions to BioC format description
  #4062 - ViewportTracker should focus on block-like elements
reckart added a commit that referenced this issue Jun 13, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
14d38be 
* main: (189 commits)
  No issue. Minor additions to BioC format description
  #4062 - ViewportTracker should focus on block-like elements
  #4032 - Allow using externalized strings from backend code
  #4060 - Clean up redundant code in annotation handlers
  #4026: Support for error tracking with Sentry
  #3673 - Update dependencies
  update dead link to the new file
  #4055 - Editor scrolls up when left sidebar is opened/closed
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-28.2
  #4052 - Admins no longer see all projects in the project overview
  #3673 - Update dependencies
  #4048 - Document navigation options not visible to manager when viewing other users document
  #3673 - Update dependencies
  #3673 - Update dependencies
  #1496 - Some spans are missing begin offset field
  #1511 - External recommender fails when CAS contains control characters
  #1496 - Some spans are missing begin offset field
  #4040 - Ability to store preferences from client-side code
  #1066 - Recommender status info
  ...

% Conflicts:
%	inception/inception-api-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/annotation/page/AnnotationPageBase.java
%	inception/inception-brat-editor/src/main/java/de/tudarmstadt/ukp/clarin/webanno/brat/annotation/BratAnnotationEditor.java
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController.java
%	inception/inception-documents/src/test/java/de/tudarmstadt/ukp/inception/documents/DocumentServiceImplConcurrencyTest.java
%	inception/inception-external-search-solr/pom.xml
%	inception/inception-html-editor/src/main/java/de/tudarmstadt/ukp/inception/htmleditor/docview/HtmlDocumentViewControllerImpl.java
%	inception/inception-html-editor/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
%	inception/inception-preferences/src/main/java/de/tudarmstadt/ukp/inception/preferences/config/PreferencesServiceAutoConfig.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/LearningRecordServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/TrainingTask.java
%	inception/inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventWebsocketControllerImplTest.java
%	inception/inception-support/pom.xml
%	inception/inception-ui-core/pom.xml
%	inception/inception-websocket/pom.xml
%	inception/pom.xml
reckart added a commit that referenced this issue Jul 2, 2023
@reckart
Merge branch 'main' into feature/1336-Add-dark-mode
d88b802 
* main:
  No issue. Slightly improving PDF editor visual
  No issue: Experiment with a Jenkinsfile
  No issue: Experiment with a Jenkinsfile
  No issue: Experiment with a Jenkinsfile
  No issue: Experiment with a Jenkinsfile
  No issue: Experiment with a Jenkinsfile
  #4058 - Cannot export texts containing certain characters as UIMA CAS XMI
  #3673 - Update dependencies
  #4066 - Display document name on export failure
  No issue. Minor additions to BioC format description
  #4062 - ViewportTracker should focus on block-like elements
  #4058 - Cannot export texts containing certain characters as UIMA CAS XMI
  #4032 - Allow using externalized strings from backend code
  #4060 - Clean up redundant code in annotation handlers
  #4026: Support for error tracking with Sentry
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
Module: JavaScript Editor API ⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
28.3
Development

No branches or pull requests
1 participant
@reckart