Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4048 - Document navigation options not visible to manager when viewing other users document #4049

Conversation

reckart
Copy link
Member

@reckart reckart commented Jun 1, 2023

What's in the PR

  • Centralize permission check for exporting documents into DocumentAccess class
  • Permission check for exporting should consider the session owner, not the document owner

How to test manually

  • Create a new project
  • Import a document
  • Add another user with the annotator and curator roles to the project
  • Enable the "Disable export in annotation views" options in the "Details" tab of the project settings
  • Disable the "Allow annotators to freely navigate between documents" in the "Workflow" tab of the project settings
  • Visit the annotation page as the user that created the project (which should be a user with the "manager" permission level) and check that the document navigation and export buttons are present
  • Use the open document dialog to open the document but this time selecting the other user from the dropdown at the top before selecting the document and check that the document navigation and export buttons are present
  • Enable the curation mode from the curation sidebar and check that the document navigation and export buttons are present
  • Copy the URL!
  • Log out and log in as the other user
  • Paste the URL to access the document directly
  • Check that the document navigation and export buttons are not present
  • Log out
  • Log back in again as the project manager
  • Use the open document dialog to open the document but this time selecting the other user from the dropdown at the top before selecting the document and check that the document navigation and export buttons are not present
  • Enable the curation mode from the curation sidebar and check that the document navigation and export buttons are not present
  • Log out
  • Log back in again as the project manager
  • Enable the "Allow annotators to freely navigate between documents" in the "Workflow" tab of the project settings
  • Log out
  • Log out and log in as the other user
  • Check that the document navigation are present and export button are not present
  • Use the open document dialog to open the document but this time selecting the other user from the dropdown at the top before selecting the document and check that the document navigation are present and export button are not present
  • Enable the curation mode from the curation sidebar and check that the document navigation are present and export button are not present
  • Mark the document as finished
  • Now also check if the export button is gone on the curation page
  • Log out
  • Log out and log in as the project manager user
  • Now also check if the export button is present on the curation page

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 28.2 milestone Jun 1, 2023
@reckart reckart self-assigned this Jun 1, 2023
…ng other users document

- Centralize permission check for exporting documents into DocumentAccess class
- Permission check for exporting should consider the session owner, not the document owner
@reckart reckart force-pushed the bugfix/4048-Document-navigation-options-not-visible-to-manager-when-viewing-other-users-document branch from b8b0c9a to 479a617 Compare June 1, 2023 19:52
@reckart reckart merged commit 3b163ea into release/28.x Jun 1, 2023
@reckart reckart deleted the bugfix/4048-Document-navigation-options-not-visible-to-manager-when-viewing-other-users-document branch June 1, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant