Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring concept feature for properties #1563

Closed
reckart opened this issue Dec 13, 2019 · 0 comments
Closed

Allow configuring concept feature for properties #1563

reckart opened this issue Dec 13, 2019 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request Module: Entity Linking Module: Fact Linking
Milestone
0.14.1

Comments

@reckart
Copy link
Member

reckart commented Dec 13, 2019

Is your feature request related to a problem? Please describe.
The concept feature can be used to link to instances and classes, but not to properties.

Describe the solution you'd like
Would be nice if it were possible to configure it for linking to properties.

Describe alternatives you've considered
We do have a dedicated PropertyFeatureSupport from the fact linking module, but it seems unnecessary at this stage to have that separate from the ConceptFeatureSupport since the SPARQLQueryBuilder supports properties nicely these days.
@reckart reckart added this to the 0.14.1 milestone Dec 13, 2019
@reckart reckart self-assigned this Dec 13, 2019
reckart added a commit that referenced this issue Dec 13, 2019
@reckart
#1563 - Allow configuring concept feature for properties
2e0b5cf 
- Add the option for linking to properties
reckart added a commit that referenced this issue Dec 13, 2019
@reckart
#1563 - Allow configuring concept feature for properties
4342a17 
- When searching for properties, force-disable FTS for Wikidata since the used FTS services does not return properties
- When FTS is disabled and startsWith or contains queries are used, then demote the label matching to a secondary condition. This should avoid listing all possible triples in the store
- Added unit test to list properties and list properties starting with a string from Wikidata
reckart added a commit that referenced this issue Dec 16, 2019
@reckart
Merge pull request #1564 from inception-project/feature/1563-Allow-co…
fcaeada 
…nfiguring-concept-feature-for-properties

#1563 - Allow configuring concept feature for properties
@reckart reckart closed this as completed Dec 16, 2019
reckart added a commit that referenced this issue Dec 17, 2019
@reckart
Merge branch '0.14.x'
fb5fab7 
* 0.14.x:
  #1567 - Cache knowledge base query results
  Revert "#1567 - Cache knowledge base query results"
  #1567 - Cache knowledge base query results
  #1567 - Cache knowledge base query results
  #1563 - Allow configuring concept feature for properties
  #1565 - Some fontawesome glyphs are no longer visible
  #1563 - Allow configuring concept feature for properties
reckart added a commit that referenced this issue Dec 17, 2019
@reckart
Merge branch 'master' into feature/46-letor-entity-linking
3d4f0fe 
* master: (21 commits)
  No issue. Mention update of demo server.
  No issue. Mention update of demo server
  #1567 - Cache knowledge base query results
  Revert "#1567 - Cache knowledge base query results"
  #1567 - Cache knowledge base query results
  #1567 - Cache knowledge base query results
  #1563 - Allow configuring concept feature for properties
  #1565 - Some fontawesome glyphs are no longer visible
  #1563 - Allow configuring concept feature for properties
  No issue. Removed unused dependency.
  #1561 - Ranking is off if there is no mention to work with
  #1559 - Problems if multiple entities have the same label
  #1559 - Problems if multiple entities have the same label
  No issue - FeatureEditors should handle their updates themselves
  #1517 - Description of KB items is cut in the concept editor
  #1517 - Description of KB items is cut in the concept editor
  #1517 - Description of KB items is cut in the concept editor
  #1549 - Filter entity candidates by description
  #1549 - Filter entity candidates by description
  No issue. Add info about CSRF and how to configure the JAR version when running behind nginx.
  ...

% Conflicts:
%	inception-concept-linking/src/main/java/de/tudarmstadt/ukp/inception/conceptlinking/ranking/BaselineRankingStrategy.java
%	inception-concept-linking/src/main/java/de/tudarmstadt/ukp/inception/conceptlinking/service/ConceptLinkingServiceImpl.java
%	inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/querybuilder/SPARQLQueryBuilder.java
%	inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/feature/ConceptFeatureEditor.java
%	inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/feature/KnowledgeBaseItemAutoCompleteField.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Entity Linking Module: Fact Linking
Projects
None yet
Milestone
0.14.1
Development

No branches or pull requests
1 participant
@reckart