Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1563 - Allow configuring concept feature for properties #1564

Merged
merged 4 commits into from
Dec 16, 2019
Merged

#1563 - Allow configuring concept feature for properties #1564

merged 4 commits into from
Dec 16, 2019

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 13, 2019

What's in the PR

  • Add the option for linking to properties

How to test manually

  • Configure a KB to provide properties, e.g. Wikidata
  • Configure the identifier property of the Named entity layer to link to properties
  • Annotate some named entities and link them to properties (semantically doesn't make sense of course, but tests the functionality)

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#1563 - Allow configuring concept feature for properties
2e0b5cf 
- Add the option for linking to properties
@reckart reckart added this to the 0.14.1 milestone Dec 13, 2019
@reckart reckart self-assigned this Dec 13, 2019
@ukp-svc-jenkins
Copy link

44% (0.0%) vs master 44%

@reckart
#1563 - Allow configuring concept feature for properties
4342a17 
- When searching for properties, force-disable FTS for Wikidata since the used FTS services does not return properties
- When FTS is disabled and startsWith or contains queries are used, then demote the label matching to a secondary condition. This should avoid listing all possible triples in the store
- Added unit test to list properties and list properties starting with a string from Wikidata
@ukp-svc-jenkins
Copy link

44% (+0.02%) vs master 44%

@reckart reckart added Needs Review and removed WIP labels Dec 16, 2019
@reckart reckart requested a review from a team December 16, 2019 11:50
@ukp-svc-jenkins
Copy link

44% (0.0%) vs master 44%

UWinch
UWinch approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@UWinch UWinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested adding properties from wine and wiki kb.

@reckart
Copy link
Member Author

reckart commented Dec 16, 2019

Yeah :)

@ukp-svc-jenkins
Copy link

44% (0.0%) vs master 44%

@reckart reckart merged commit fcaeada into 0.14.x Dec 16, 2019
@reckart reckart deleted the feature/1563-Allow-configuring-concept-feature-for-properties branch December 16, 2019 16:05
jcklie pushed a commit that referenced this pull request Feb 2, 2021
@reckart
#1564 - Bulk-dismiss of errors and warnings no longer works
2ae4703 
- Fix and simplify visibility condition for dismiss-all option
- Turn from a link into a button which is more prominent
jcklie pushed a commit that referenced this pull request Feb 2, 2021
@reckart
Merge branch '3.6.x'
6553a7a 
* 3.6.x:
  #1564 - Bulk-dismiss of errors and warnings no longer works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UWinch UWinch UWinch approved these changes

Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Entity Linking Module: Fact Linking
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.
3 participants
@reckart @ukp-svc-jenkins @UWinch