Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter entity candidates by description #1549

Closed
reckart opened this issue Dec 3, 2019 · 0 comments
Closed

Filter entity candidates by description #1549

reckart opened this issue Dec 3, 2019 · 0 comments
Assignees
@jcklie @reckart
Labels
⭐️ Enhancement New feature or request Module: Entity Linking
Milestone
0.14.1

Comments

@reckart
Copy link
Member

reckart commented Dec 3, 2019

Is your feature request related to a problem? Please describe.
Searching for an entity matches against the label of the entity in the knowledge base. The description is not considered. Also, searching in the description of all entities would not be terribly helpful because it would likely generate way too many results.

Describe the solution you'd like
I would like to enter something like county :: queen into the KB feature editor. The expected behavior is that the usual match against the KB label is done using the part before the :: - so we retrieve any items matching county in the label. Afterwards, the term after the :: is used to match in the description. So here, any matching KB items with the term queen in their description should be matched. The usual Levenshtein-distance match should be applied to the description match and the items should be ranked according to the distance.

Describe alternatives you've considered
Searching in the description of all entities would not be terribly helpful because it would likely generate way too many results.
@reckart reckart added this to the 0.15.0 milestone Dec 3, 2019
@reckart reckart changed the title Search in descriptions Filter entity candidates by description Dec 3, 2019
reckart added a commit that referenced this issue Dec 4, 2019
@reckart
#1549 - Filter entity candidates by description
cf2299b 
- Allow filtering candidates by description using `::` separator
- Allow filtering candidates by label using `"..."` quoting
@reckart reckart self-assigned this Dec 4, 2019
reckart added a commit that referenced this issue Dec 5, 2019
@reckart
#1549 - Filter entity candidates by description
440208e 
- Allow filtering candidates by description using `::` separator
- Allow filtering candidates by label using `"..."` quoting
- Added documentation for the new features
reckart added a commit that referenced this issue Dec 9, 2019
@reckart
#1549 - Filter entity candidates by description
99b659d 
- Fix issue that no results are returned if there is whitespace before the first double-quote when filtering by label
reckart added a commit that referenced this issue Dec 9, 2019
@reckart
#1549 - Filter entity candidates by description
7b181b9 
- Fix issue that passing the unprocessed input value to the concept linking service when enclosing the query with quotes instead of the input wih the quotes removed
reckart added a commit that referenced this issue Dec 10, 2019
@reckart
Merge pull request #1554 from inception-project/feature/1549-Filter-e…
c84f9ef 
…ntity-candidates-by-description

#1549 - Filter entity candidates by description
@reckart reckart closed this as completed Dec 10, 2019
@reckart reckart reopened this Dec 16, 2019
@reckart reckart modified the milestones: 0.15.0, 0.14.1 Dec 16, 2019
reckart added a commit that referenced this issue Dec 16, 2019
@reckart
#1549 - Filter entity candidates by description
ce0764d 
- Allow filtering candidates by description using `::` separator
- Allow filtering candidates by label using `"..."` quoting
- Added documentation for the new features
reckart added a commit that referenced this issue Dec 17, 2019
@reckart
Merge branch 'master' into feature/46-letor-entity-linking
3d4f0fe 
* master: (21 commits)
  No issue. Mention update of demo server.
  No issue. Mention update of demo server
  #1567 - Cache knowledge base query results
  Revert "#1567 - Cache knowledge base query results"
  #1567 - Cache knowledge base query results
  #1567 - Cache knowledge base query results
  #1563 - Allow configuring concept feature for properties
  #1565 - Some fontawesome glyphs are no longer visible
  #1563 - Allow configuring concept feature for properties
  No issue. Removed unused dependency.
  #1561 - Ranking is off if there is no mention to work with
  #1559 - Problems if multiple entities have the same label
  #1559 - Problems if multiple entities have the same label
  No issue - FeatureEditors should handle their updates themselves
  #1517 - Description of KB items is cut in the concept editor
  #1517 - Description of KB items is cut in the concept editor
  #1517 - Description of KB items is cut in the concept editor
  #1549 - Filter entity candidates by description
  #1549 - Filter entity candidates by description
  No issue. Add info about CSRF and how to configure the JAR version when running behind nginx.
  ...

% Conflicts:
%	inception-concept-linking/src/main/java/de/tudarmstadt/ukp/inception/conceptlinking/ranking/BaselineRankingStrategy.java
%	inception-concept-linking/src/main/java/de/tudarmstadt/ukp/inception/conceptlinking/service/ConceptLinkingServiceImpl.java
%	inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/querybuilder/SPARQLQueryBuilder.java
%	inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/feature/ConceptFeatureEditor.java
%	inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/feature/KnowledgeBaseItemAutoCompleteField.java
reckart added a commit that referenced this issue Dec 18, 2019
@reckart
Merge pull request #1569 from inception-project/feature/1549-Filter-e…
263480e 
…ntity-candidates-by-description

#1549 - Filter entity candidates by description
@reckart reckart closed this as completed Dec 18, 2019
reckart added a commit that referenced this issue Dec 18, 2019
@reckart
Merge branch '0.14.x' into feature/1572-Safeguard-CAS-against-concurr…
ab92549 
…ent-accesses

* 0.14.x:
  #1570 - External recommender forgets to close responses
  #1549 - Filter entity candidates by description

% Conflicts:
%	inception-imls-external/src/main/java/de/tudarmstadt/ukp/inception/recommendation/imls/external/ExternalRecommender.java
@reckart reckart reopened this Dec 18, 2019
reckart added a commit that referenced this issue Dec 18, 2019
@reckart
#1549 - Filter entity candidates by description
a603f43 
- Trim description filter such that e.g. "chicago :: city" would matching something having "city" at the start of the description (i.e. without leading space)
- Add more comments to the candidate generation code and slightly clean up the code which decides when to make which type of matching
reckart added a commit that referenced this issue Dec 19, 2019
@reckart
#1549 - Filter entity candidates by description
e2dd807 
- Fixed import
reckart added a commit that referenced this issue Dec 19, 2019
@reckart
Merge pull request #1577 from inception-project/feature/1549-Filter-e…
9f03a97 
…ntity-candidates-by-description

#1549 - Filter entity candidates by description
@reckart reckart closed this as completed Dec 19, 2019
reckart added a commit that referenced this issue Dec 19, 2019
@reckart
Merge branch '0.14.x'
d343951 
* 0.14.x:
  #1549 - Filter entity candidates by description
  #1572 - Safeguard CAS against concurrent accesses
  #1549 - Filter entity candidates by description
  #1572 - Safeguard CAS against concurrent accesses
  #1548 - Suggestions disappear if recommender fails
  #1570 - External recommender forgets to close responses
  #1549 - Filter entity candidates by description
  #1548 - Suggestions disappear if recommender fails
  #1548 - Suggestions disappear if recommender fails
  #1548 - Suggestions disappear if recommender fails

% Conflicts:
%	inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/feature/ConceptFeatureEditor.java
reckart added a commit that referenced this issue Dec 22, 2019
@reckart
Merge branch 'master' into feature/46-letor-entity-linking
8418c68 
* master:
  No issue. Back to WebAnno SNAPSHOT version.
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-app-0.14.1
  No issue. Depend on WebAnno 4.0.0-beta-8 for release.
  No issue. Use placeholder mechanism of SLF4J instead of String.format.
  No issue. Adjust to upstream API change.
  #1549 - Filter entity candidates by description
  #1572 - Safeguard CAS against concurrent accesses
  #1549 - Filter entity candidates by description
  #1572 - Safeguard CAS against concurrent accesses
  #1548 - Suggestions disappear if recommender fails
  #1570 - External recommender forgets to close responses
  #1549 - Filter entity candidates by description
  #1548 - Suggestions disappear if recommender fails
  #1548 - Suggestions disappear if recommender fails
  #1548 - Suggestions disappear if recommender fails

% Conflicts:
%	inception-concept-linking/src/main/java/de/tudarmstadt/ukp/inception/conceptlinking/service/ConceptLinkingServiceImpl.java
%	inception-imls-external/src/main/java/de/tudarmstadt/ukp/inception/recommendation/imls/external/ExternalRecommender.java
%	inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
reckart added a commit that referenced this issue Jan 1, 2020
@reckart
Merge branch 'master' into feature/1256-curation-into-annotationpage
43139b7 
* master: (37 commits)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-app-0.14.2
  #1587 - Disable fact linking support
  #1587 - Disable fact linking support
  No issue. Depend on WebAnno 4.0.0 beta 9 for next release.
  #1587 - Disable fact linking support
  #1582 - Support IMS CWB format
  #1582 - Support IMS CWB format
  #1581 - Update and modularize format documentation
  No issue. Back to WebAnno SNAPSHOT version.
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-app-0.14.1
  No issue. Depend on WebAnno 4.0.0-beta-8 for release.
  No issue. Use placeholder mechanism of SLF4J instead of String.format.
  No issue. Adjust to upstream API change.
  #1549 - Filter entity candidates by description
  #1572 - Safeguard CAS against concurrent accesses
  #1549 - Filter entity candidates by description
  #1572 - Safeguard CAS against concurrent accesses
  #1548 - Suggestions disappear if recommender fails
  ...
reckart added a commit that referenced this issue Jan 1, 2020
@reckart
Merge branch 'master' into feature/1294-Add-more-feature-config-switches
1f46877 
* master: (49 commits)
  #1575 - Use fuzzy search for entity linking
  #1575 - Use fuzzy search for entity linking
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-app-0.14.2
  #1587 - Disable fact linking support
  #1587 - Disable fact linking support
  No issue. Depend on WebAnno 4.0.0 beta 9 for next release.
  #1587 - Disable fact linking support
  #1582 - Support IMS CWB format
  #1575 - Use fuzzy search for entity linking
  #1582 - Support IMS CWB format
  #1581 - Update and modularize format documentation
  No issue. Back to WebAnno SNAPSHOT version.
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-app-0.14.1
  No issue. Depend on WebAnno 4.0.0-beta-8 for release.
  No issue. Use placeholder mechanism of SLF4J instead of String.format.
  No issue. Adjust to upstream API change.
  #1549 - Filter entity candidates by description
  #1572 - Safeguard CAS against concurrent accesses
  ...

% Conflicts:
%	inception-concept-linking/src/test/java/de/tudarmstadt/ukp/inception/conceptlinking/service/ConceptLinkingServiceImplTest.java
%	inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/KnowledgeBaseServiceImpl.java
%	inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/config/KnowledgeBasePropertiesImpl.java
%	inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/initializers/FactLayerInitializer.java
reckart added a commit that referenced this issue Jan 5, 2020
@reckart
Merge branch 'master' into feature/1239-simple-relation-recommender
e8c7936 
* master: (29 commits)
  No issue. Fix compilation.
  #1575 - Use fuzzy search for entity linking
  #1575 - Use fuzzy search for entity linking
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-app-0.14.2
  #1587 - Disable fact linking support
  #1587 - Disable fact linking support
  No issue. Depend on WebAnno 4.0.0 beta 9 for next release.
  #1587 - Disable fact linking support
  #1582 - Support IMS CWB format
  #1575 - Use fuzzy search for entity linking
  #1582 - Support IMS CWB format
  #1581 - Update and modularize format documentation
  No issue. Back to WebAnno SNAPSHOT version.
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-app-0.14.1
  No issue. Depend on WebAnno 4.0.0-beta-8 for release.
  No issue. Use placeholder mechanism of SLF4J instead of String.format.
  No issue. Adjust to upstream API change.
  #1549 - Filter entity candidates by description
  ...

% Conflicts:
%	inception-recommendation-api/src/main/java/de/tudarmstadt/ukp/inception/recommendation/api/RecommendationService.java
%	inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge pull request #1549 from webanno/bugfix/1535-Export-to-CoNLL-201…
0f87bb2 
…2-format-has-duplicate-V

#1535 - Export to CoNLL 2012 format has duplicate (V*) tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcklie jcklie

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Entity Linking
Projects
None yet
Milestone
0.14.1
Development

No branches or pull requests
2 participants
@jcklie @reckart