Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard shortcuts do not work when focus is in certain editors #1535

Closed
XiaZeng0223 opened this issue Nov 27, 2019 · 0 comments
Closed

Keyboard shortcuts do not work when focus is in certain editors #1535

XiaZeng0223 opened this issue Nov 27, 2019 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: JavaScript Editor API Module: PDF editor
Milestone
27.0

Comments

@XiaZeng0223
Copy link

Describe the bug
Keyboard shortcut doesn't work properly with pdf documents. We have to first escape the iframe of pdf by clicking somewhere outside of pdf documents and then use the shortcut.

Expected behavior
Be able to use keyboard shortcuts directly while annotating with pdf documents. Or press a shortcut key to enable that.

Please complete the following information:

  • Version and build ID: [see bottom of the browser screen]
  • OS: Linux
  • Browser: chrome
@reckart reckart added Module: PDF editor 🐛Bug Something isn't working labels Nov 27, 2019
@reckart reckart modified the milestones: Bug backlog, 0.14.1 Nov 27, 2019
@reckart reckart self-assigned this Dec 3, 2019
@reckart reckart modified the milestones: 0.14.1, 0.14.2 Dec 16, 2019
@reckart reckart modified the milestones: 0.14.2, 0.14.3 Dec 31, 2019
@UWinch UWinch modified the milestones: 0.14.3, Bug backlog Jan 30, 2020
@reckart reckart removed their assignment Jan 18, 2021
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
#1535 - Export to CoNLL 2012 format has duplicate (V*) tags
9e5bf02 
- Upgrading to new DKPro Core version which has this issue fixed
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
#1535 - Export to CoNLL 2012 format has duplicate (V*) tags
a6fa79c 
- Remove unused dependencies
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge pull request #1549 from webanno/bugfix/1535-Export-to-CoNLL-201…
0f87bb2 
…2-format-has-duplicate-V

#1535 - Export to CoNLL 2012 format has duplicate (V*) tags
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge branch '3.6.x'
c1665ce 
* 3.6.x:
  #1535 - Export to CoNLL 2012 format has duplicate (V*) tags
  #1535 - Export to CoNLL 2012 format has duplicate (V*) tags

% Conflicts:
%	pom.xml
%	webanno-io-conll/pom.xml
%	webanno-io-conll/src/main/java/de/tudarmstadt/ukp/clarin/webanno/conll/ConllUFormatSupport.java
%	webanno-io-conll/src/main/java/de/tudarmstadt/ukp/clarin/webanno/conll/ConllUWriter.java
%	webanno-plugin-api/src/main/java/de/tudarmstadt/ukp/clarin/webanno/plugin/api/PluginManager.java
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
#1535 - Export to CoNLL 2012 format has duplicate (V*) tags
b8ac8a2 
- Upgrade to DKPro Core 2.1.0 for the required fixes to the CoNLL 2012 reader/writer
@reckart reckart changed the title keyboard shortcut doesn't work properly with pdf documents Keyboard shortcuts do not work when focus is in certain editors Jan 1, 2023
@reckart reckart self-assigned this Jan 1, 2023
@reckart reckart modified the milestones: 🦟 Bug backlog, 27.0 Jan 1, 2023
reckart added a commit that referenced this issue Jan 1, 2023
@reckart
#1535 - Keyboard shortcuts do not work when focus is in certain editors
89cdb2e 
- Add a forwarding of keyboard events from within the iframe to the outside document
reckart added a commit that referenced this issue Jan 1, 2023
@reckart
Merge pull request #3674 from inception-project/bugfix/1535-Keyboard-…
5995ffa 
…shortcuts-do-not-work-when-focus-is-in-certain-editors

#1535 - Keyboard shortcuts do not work when focus is in certain editors
@reckart reckart closed this as completed Jan 1, 2023
reckart added a commit that referenced this issue Jan 4, 2023
@reckart
Merge branch 'main' into feature/3411-Resize-sidebars-using-mouse
9df73b4 
* main:
  #3610 - Minimizing icon in document level feature is wrong after updating feature
  #3656 - The color of the existing layers changes after adding another layer
  #3679 - NullPointerException during export in WebAnno format
  #283 - Resize span
  #283 - Resize span
  #283 - Resize span
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3676 - Error when rejecting annotation suggestion
  #3675 - Clean up more brat code
  #1535 - Keyboard shortcuts do not work when focus is in certain editors
  #3571 - Update dependencies
  #3670 - Remove LIF support
  #3670 - Remove LIF support
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-26.3
  #3650 - Link label shows layer name instead of label
reckart added a commit that referenced this issue Jan 4, 2023
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
2ff4386 
* main: (64 commits)
  #3610 - Minimizing icon in document level feature is wrong after updating feature
  #3656 - The color of the existing layers changes after adding another layer
  #3679 - NullPointerException during export in WebAnno format
  #283 - Resize span
  #283 - Resize span
  #283 - Resize span
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3676 - Error when rejecting annotation suggestion
  #3675 - Clean up more brat code
  #1535 - Keyboard shortcuts do not work when focus is in certain editors
  #3571 - Update dependencies
  #3670 - Remove LIF support
  #3670 - Remove LIF support
  #3668 - Disable tutorial for now
  #3664 - Avoid server-side HTML composition not using Wicket
  #3664 - Avoid server-side HTML composition not using Wicket
  #283 - Resize span
  #3660 - Option to disable span clipping
  ...
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: JavaScript Editor API Module: PDF editor
Projects
Kanban
Archived in project
Milestone
27.0
Development

No branches or pull requests
3 participants
@reckart @UWinch @XiaZeng0223