Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up more brat code #3675

Closed
reckart opened this issue Jan 1, 2023 · 0 comments
Closed

Clean up more brat code #3675

reckart opened this issue Jan 1, 2023 · 0 comments
Assignees
@reckart
Labels
Module: brat ⚙️ Refactoring
Milestone
27.0

Comments

@reckart
Copy link
Member

reckart commented Jan 1, 2023

Describe the refactoring action
Clean up more of the brat code, in particular code in the AnnotatorUI.ts

Expected benefit
Cleaner code.
@reckart reckart added this to the 27.0 milestone Jan 1, 2023
@reckart reckart self-assigned this Jan 1, 2023
reckart added a commit that referenced this issue Jan 1, 2023
@reckart
#3675 - Clean up more brat code
f3cdd03 
- Clean up a few warnings
- Send extension actions through DIAM
reckart added a commit that referenced this issue Jan 1, 2023
@reckart
#3675 - Clean up more brat code
20ff60b 
- Comment out / remove unused code
reckart added a commit that referenced this issue Jan 1, 2023
@reckart
#3675 - Clean up more brat code
f7d05ce 
- Comment out / remove unused code#
- Fix highlighting relation drag targets
reckart added a commit that referenced this issue Jan 1, 2023
@reckart
#3675 - Clean up more brat code
39f6032 
- Comment out / remove unused code#
- Add more types
- Use more modern APIs
reckart added a commit that referenced this issue Jan 3, 2023
@reckart
Merge pull request #3677 from inception-project/refactoring/3675-Clea…
6e19942 
…n-up-more-brat-code

#3675 - Clean up more brat code
@reckart reckart closed this as completed Jan 3, 2023
reckart added a commit that referenced this issue Jan 4, 2023
@reckart
Merge branch 'main' into feature/3411-Resize-sidebars-using-mouse
9df73b4 
* main:
  #3610 - Minimizing icon in document level feature is wrong after updating feature
  #3656 - The color of the existing layers changes after adding another layer
  #3679 - NullPointerException during export in WebAnno format
  #283 - Resize span
  #283 - Resize span
  #283 - Resize span
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3676 - Error when rejecting annotation suggestion
  #3675 - Clean up more brat code
  #1535 - Keyboard shortcuts do not work when focus is in certain editors
  #3571 - Update dependencies
  #3670 - Remove LIF support
  #3670 - Remove LIF support
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-26.3
  #3650 - Link label shows layer name instead of label
reckart added a commit that referenced this issue Jan 4, 2023
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
2ff4386 
* main: (64 commits)
  #3610 - Minimizing icon in document level feature is wrong after updating feature
  #3656 - The color of the existing layers changes after adding another layer
  #3679 - NullPointerException during export in WebAnno format
  #283 - Resize span
  #283 - Resize span
  #283 - Resize span
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3676 - Error when rejecting annotation suggestion
  #3675 - Clean up more brat code
  #1535 - Keyboard shortcuts do not work when focus is in certain editors
  #3571 - Update dependencies
  #3670 - Remove LIF support
  #3670 - Remove LIF support
  #3668 - Disable tutorial for now
  #3664 - Avoid server-side HTML composition not using Wicket
  #3664 - Avoid server-side HTML composition not using Wicket
  #283 - Resize span
  #3660 - Option to disable span clipping
  ...
reckart added a commit that referenced this issue Jan 21, 2023
@reckart
#3675 - Clean up more brat code
c280e6a 
- Fix highlight CSS
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
Module: brat ⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
27.0
Development

No branches or pull requests
1 participant
@reckart