Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link label shows layer name instead of label #3650

Closed
pa-nlp opened this issue Dec 20, 2022 · 3 comments
Closed

Link label shows layer name instead of label #3650

pa-nlp opened this issue Dec 20, 2022 · 3 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Annotation
Milestone
26.3

Comments

@pa-nlp
Copy link

pa-nlp commented Dec 20, 2022 •
edited
Loading

Describe the bug
Link labels display the tagset name (or layer name, which is the same in our project) instead of the selected value from the tagset as before. The correct value is still there if the data is exported or the link selected (shown in the right detail panel).

To Reproduce
The server was updgraded from 25.4 to 26.2 with an existing project with custom layers for semantic role labeling using custom tagsets for links.

Expected behavior
The link should display the value selected from the tagset instead of the tagset name.

Screenshots
This is the new, invalid display of the tagset name on every link with version 26.2

new_version

But it used to show the values in the previous installed version 25.4 like this

previous_version

Please complete the following information:

  • Version and build ID: 26.2 (2022-12-20 19:01:06, build f3ea5ca)
  • OS: Linux
  • Browser: chrome v108.0.5359.124

Additional context
@pa-nlp pa-nlp changed the title Link label show tagset name instead of selected value Link label shows tagset name instead of selected value Dec 20, 2022
@reckart
Copy link
Member

reckart commented Dec 20, 2022

Indeed. Thanks for the report. I'll have a look.

@reckart reckart added this to the 26.3 milestone Dec 20, 2022
@reckart
Copy link
Member

reckart commented Dec 20, 2022

As ARG the tagset name or the layer name in your case?

@pa-nlp
Copy link
Author

pa-nlp commented Dec 20, 2022

Both are the same, but I changed the layer name and it changed in the display for all the links. So basically it's not the tagset name that is displayed, it's the layer name.

@reckart reckart changed the title Link label shows tagset name instead of selected value Link label shows layer name instead of label Dec 21, 2022
@reckart reckart self-assigned this Dec 21, 2022
@reckart reckart added 🐛Bug Something isn't working Module: Annotation labels Dec 21, 2022
reckart added a commit that referenced this issue Dec 21, 2022
@reckart
#3650 - Link label shows layer name instead of label
02a7879 
- Avoid LabelRenderer step overriding label hints that were set earlier in the rendering process
reckart added a commit that referenced this issue Dec 21, 2022
@reckart
Merge pull request #3651 from inception-project/bugfix/3650-Link-labe…
9e512ba 
…l-shows-layer-name-instead-of-label

#3650 - Link label shows layer name instead of label
@reckart reckart closed this as completed Dec 21, 2022
@reckart reckart mentioned this issue Dec 22, 2022
Closed
reckart added a commit that referenced this issue Jan 4, 2023
@reckart
Merge branch 'main' into feature/3411-Resize-sidebars-using-mouse
9df73b4 
* main:
  #3610 - Minimizing icon in document level feature is wrong after updating feature
  #3656 - The color of the existing layers changes after adding another layer
  #3679 - NullPointerException during export in WebAnno format
  #283 - Resize span
  #283 - Resize span
  #283 - Resize span
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3675 - Clean up more brat code
  #3676 - Error when rejecting annotation suggestion
  #3675 - Clean up more brat code
  #1535 - Keyboard shortcuts do not work when focus is in certain editors
  #3571 - Update dependencies
  #3670 - Remove LIF support
  #3670 - Remove LIF support
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-26.3
  #3650 - Link label shows layer name instead of label
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
Archived in project
Milestone
26.3
Development

No branches or pull requests
2 participants
@reckart @pa-nlp