Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems if multiple entities have the same label #1559

Closed
reckart opened this issue Dec 11, 2019 · 0 comments
Closed

Problems if multiple entities have the same label #1559

reckart opened this issue Dec 11, 2019 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Entity Linking
Milestone
0.14.1

Comments

@reckart
Copy link
Member

reckart commented Dec 11, 2019 •
edited
Loading

Describe the bug
The KB autocomplete field fails to send the right selection to the backend if multiple items in the dropdown list have the same label. This is because the Kendo auto-complete JS code assumes that every item has a different label and otherwise does not properly trigger change events amongst other problems. But also the Wicket KendoAutoComplete backend code makes the same assumption and selects the always the first item with the given label.

To Reproduce
Steps to reproduce the behavior:

  1. Configure Wikidata as a KB
  2. Try to link some word to Chicago
  3. There are multiple items in Wikidata with this label. Try to select the first one, then try to select the second one.
  4. You should note that after selecting the second one, the linked item is actually still the first one.

Expected behavior
The frontend should send the IRI of the concept back to the server and the server should use that to make the selection.

Please complete the following information:

  • Version and build ID: 0.14.0

Additional context
@reckart reckart added 🐛Bug Something isn't working Module: Entity Linking labels Dec 11, 2019
@reckart reckart added this to the 0.14.1 milestone Dec 11, 2019
@reckart reckart self-assigned this Dec 11, 2019
@reckart reckart mentioned this issue Dec 11, 2019
Closed
reckart added a commit that referenced this issue Dec 11, 2019
@reckart
#1559 - Problems if multiple entities have the same label
cf7e9a1 
- Fixes issue of items with the same label being confused by frontend and backend by using IRI as an identifier
- Improve performance of linking an entity by not fetching the choices again if we still have them from filling the dropdown
- Avoid sending redundant data to the UI
- Add area with entity description below the entity linking field
reckart added a commit that referenced this issue Dec 12, 2019
@reckart
#1559 - Problems if multiple entities have the same label
1e1158c 
- Pull code which is only required for the concept feature editor into the that one creating an inner class with additional modifications of the KnowledgeBaseItemAutoCompleteField
- Leave generic code not in the KnowledgeBaseItemAutoCompleteField so that it can be used on the KB page for the search field and for the IRI value editor
- Removed unused dependency
reckart added a commit that referenced this issue Dec 12, 2019
@reckart
Merge pull request #1560 from inception-project/bugfix/1559-Problems-…
eef5d77 
…if-multiple-entities-have-the-same-label

#1559 - Problems if multiple entities have the same label
@reckart reckart closed this as completed Dec 12, 2019
reckart added a commit that referenced this issue Dec 13, 2019
@reckart
Merge branch '0.14.x'
000580b 
* 0.14.x:
  #1561 - Ranking is off if there is no mention to work with
  #1559 - Problems if multiple entities have the same label
  #1559 - Problems if multiple entities have the same label

% Conflicts:
%	inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/feature/ConceptFeatureEditor.java
reckart added a commit that referenced this issue Dec 17, 2019
@reckart
Merge branch 'master' into feature/46-letor-entity-linking
3d4f0fe 
* master: (21 commits)
  No issue. Mention update of demo server.
  No issue. Mention update of demo server
  #1567 - Cache knowledge base query results
  Revert "#1567 - Cache knowledge base query results"
  #1567 - Cache knowledge base query results
  #1567 - Cache knowledge base query results
  #1563 - Allow configuring concept feature for properties
  #1565 - Some fontawesome glyphs are no longer visible
  #1563 - Allow configuring concept feature for properties
  No issue. Removed unused dependency.
  #1561 - Ranking is off if there is no mention to work with
  #1559 - Problems if multiple entities have the same label
  #1559 - Problems if multiple entities have the same label
  No issue - FeatureEditors should handle their updates themselves
  #1517 - Description of KB items is cut in the concept editor
  #1517 - Description of KB items is cut in the concept editor
  #1517 - Description of KB items is cut in the concept editor
  #1549 - Filter entity candidates by description
  #1549 - Filter entity candidates by description
  No issue. Add info about CSRF and how to configure the JAR version when running behind nginx.
  ...

% Conflicts:
%	inception-concept-linking/src/main/java/de/tudarmstadt/ukp/inception/conceptlinking/ranking/BaselineRankingStrategy.java
%	inception-concept-linking/src/main/java/de/tudarmstadt/ukp/inception/conceptlinking/service/ConceptLinkingServiceImpl.java
%	inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/querybuilder/SPARQLQueryBuilder.java
%	inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/feature/ConceptFeatureEditor.java
%	inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/feature/KnowledgeBaseItemAutoCompleteField.java
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge pull request #1559 from webanno/bugfix/1558-Opening-the-annotat…
9068bca 
…ions-of-another-user-updates-CAS

#1558 - Opening the annotations of another user updates CAS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Entity Linking
Projects
None yet
Milestone
0.14.1
Development

No branches or pull requests
1 participant
@reckart