Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1559 - Problems if multiple entities have the same label #1560

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 11, 2019

What's in the PR

  • Fixes issue of items with the same label being confused by frontend and backend by using IRI as an identifier
  • Improve performance of linking an entity by not fetching the choices again if we still have them from filling the dropdown
  • Avoid sending redundant data to the UI
  • Add area with entity description below the entity linking field

How to test manually

  • See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Fixes issue of items with the same label being confused by frontend and backend by using IRI as an identifier
- Improve performance of linking an entity by not fetching the choices again if we still have them from filling the dropdown
- Avoid sending redundant data to the UI
- Add area with entity description below the entity linking field
@reckart reckart added 🐛 Bug Something isn't working Module: Entity Linking labels Dec 11, 2019
@reckart reckart added this to the 0.14.1 milestone Dec 11, 2019
@reckart reckart self-assigned this Dec 11, 2019
@reckart reckart requested a review from a team December 11, 2019 21:34
@jcklie
Copy link
Contributor

jcklie commented Dec 12, 2019

@reckart Build fails

Copy link
Contributor

@jcklie jcklie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@reckart
Copy link
Member Author

reckart commented Dec 12, 2019

Has issues - the current state breaks e.g. search on the KB page. I'm looking into it again.

- Pull code which is only required for the concept feature editor into the that one creating an inner class with additional modifications of the KnowledgeBaseItemAutoCompleteField
- Leave generic code not in the KnowledgeBaseItemAutoCompleteField so that it can be used on the KB page for the search field and for the IRI value editor
- Removed unused dependency
@ukp-svc-jenkins
Copy link

44% (+0.02%) vs master 44%

@ukp-svc-jenkins
Copy link

44% (+0.02%) vs master 44%

@reckart reckart merged commit eef5d77 into 0.14.x Dec 12, 2019
@reckart reckart deleted the bugfix/1559-Problems-if-multiple-entities-have-the-same-label branch December 12, 2019 18:43
jcklie pushed a commit that referenced this pull request Feb 2, 2021
…-and-dependency-tagsets

#1521 - Upgrade to UDv2 POS and dependency tagsets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Module: Entity Linking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants