-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1559 - Problems if multiple entities have the same label #1560
Merged
reckart
merged 3 commits into
0.14.x
from
bugfix/1559-Problems-if-multiple-entities-have-the-same-label
Dec 12, 2019
Merged
#1559 - Problems if multiple entities have the same label #1560
reckart
merged 3 commits into
0.14.x
from
bugfix/1559-Problems-if-multiple-entities-have-the-same-label
Dec 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes issue of items with the same label being confused by frontend and backend by using IRI as an identifier - Improve performance of linking an entity by not fetching the choices again if we still have them from filling the dropdown - Avoid sending redundant data to the UI - Add area with entity description below the entity linking field
@reckart Build fails |
jcklie
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
Has issues - the current state breaks e.g. search on the KB page. I'm looking into it again. |
- Pull code which is only required for the concept feature editor into the that one creating an inner class with additional modifications of the KnowledgeBaseItemAutoCompleteField - Leave generic code not in the KnowledgeBaseItemAutoCompleteField so that it can be used on the KB page for the search field and for the IRI value editor - Removed unused dependency
…have-the-same-label
reckart
deleted the
bugfix/1559-Problems-if-multiple-entities-have-the-same-label
branch
December 12, 2019 18:43
jcklie
pushed a commit
that referenced
this pull request
Feb 2, 2021
…-and-dependency-tagsets #1521 - Upgrade to UDv2 POS and dependency tagsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation