-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta release: 20181030.0 + 20181103.0 #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract navigate to function * Remove eventsmixin properly and side effects
* Thermostat fix * Fix for unknown operation mode * No title for you * I suck at removing unnecessary things * Fixing pointless Ternary operator
* Fix hass setting on stack * Don't set hass on pic elements if undefined * Don't set hass on entity rows if undefined * prefix config prop * Pic elements set hass yoooo * Remove interface * Make stack config private * Fix import * Lint
…Click mixin functions
Was unable to get computeTooltip to work for non-converted elements. There are not many elements that use this so will just remove this mixin once conversion of all to TS has been completed.
Fix linting error
Convert hui-icon-element to TypeScript/LitElement
Make hass optional within EntityRow as it may not be defined
The choice of the "fan-off" icon to set the climate operation_mode to off should be changed . Many HVAC thermostats have a manual fan control. The use of the fan icon in this card would imply that it would change or toggle the fan_mode of a climate component, not the operation_mode. If setting the fan_mode of a climate component via this card were to be implemented in the future the use of "fan" and "fan-off" icons would be the most logical choices for icons. I propose changing the icon that would set the operation_mode to off to generic power icon such as "power", or "power-off" to avoid confusion and to reserve the "fan" and "fan-off" icons for future use to change the the state of fan_mode.
* Convert hui-service-button-element to TypeScript/LitElement Will need to rebase once hui-icon-element PR is merged * Added return types * Convert ha-call-service-button attributes to properties * Re-order imports
* Handle no operation mode * Upgrade HAWS so we can use correct types * Lint
* Convert hui-image-element to TypeScript/LitElement WIP Some of the state portions passed down to ha-image are not updating the view. * Fixed setting of properties * Add tagnamemap interface * Address review comments
* Convert hui-state-icon-element to TypeScript/LitElement The icon is not currently dispalying and therefor cannot determine if changing as well. Everything else is working. Should probably create a base class for all these elements to extend for simple things like checking for the entity and setting hass correctly once I get that sorted out. * Fixed setting of properties * Remove ! on this._config * Addressed review comments * Moved event handlers to private functions to avoid arrow function creation on each render * Check for `hass` before looking for state * Movevd absolute import above relative imports
* Convert hui-state-badge-element to TypeScript/LitElement The state image is not updating. This is true with the image-element as well. There's probably something simple between them both that I'm missing in my syntax for defining them * Added htmlmap interface * Addressed review comments
* Gauge convert and fix issues * Fixing Unit_of_Measurement * Addressing Reviews * Updating typing
* Convert hui-divider-row to TypeScript/LitElement * Add return types * Fixed style issues * Address review comments
* Convert hui-weblink-row to TypeScript/LitElement * Addressed review comments * Made name and icon fields optional. Will create a corresponding PR to the docs to update them as Optional * Updated entities-card to not check weblink config as that is the job of the element (entities-card should be updated to not check service-call config either as that is the job of the row element as well) * Addressed review comments That's cool!
* Convert hui-climate-entity-row to TypeScript/LitElement * Address review comments * Address review comments
* Thermostat fix (#1867) * Thermostat fix * Fix for unknown operation mode * No title for you * I suck at removing unnecessary things * Fixing pointless Ternary operator * Add version bump script * Fix hass setting on stack (#1868) * Fix hass setting on stack * Don't set hass on pic elements if undefined * Don't set hass on entity rows if undefined * prefix config prop * Pic elements set hass yoooo * Remove interface * Make stack config private * Fix import * Lint * Bumped version to 20181026.1 * 🔨 move not text to header and name to secondary text * 🔨 reduce some other margins
* Convert hui-section-row to TypeScript/LitElement * Address review comments
* Update Types * Travis fix * Travis change * Add HTMLElementTagNameMap for gauge * Review Changes * Formatting values as string to be accepted into format temp
* Remove side effects of render and Add types * Addressing changes * Updating when to apply theme * Review Updates * Fixing last reviews * Updates from travis
* Remove .js from lovelace Also cleaned up some trailing whitespace * Go big or go home * More removals * Revert changes to gallery webpack * Revert changes to webpack.config.js
* New warning row for non-existent entities * Update src/panels/lovelace/entity-rows/hui-error-entity-row.ts * Address my own comments
* Update to have theme options * Make ShouldUpdate into a help function * Adding types to changed function
* POC for RTL support * POC for RTL support * POC for RTL support
ghost
assigned balloob
Nov 3, 2018
ghost
added
the
in progress
label
Nov 3, 2018
ghost
removed
the
in progress
label
Nov 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20181030.0
20181103.0