Handle no operation mode #1901
Merged
Handle no operation mode #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
balloob
commented
Oct 28, 2018
src/types.ts
Outdated
| @@ -85,3 +86,27 @@ export interface HomeAssistant { | |||
| sendWS: (msg: MessageBase) => Promise<void>; | |||
| callWS: <T>(msg: MessageBase) => Promise<T>; | |||
| } | |||
|
|
|||
| export type ClimateEntity = HassEntity & { | |||
There was a problem hiding this comment.
This is kinda annoying as HassEntity also defines attributes = {[s: string]: any}, which means autocomplete doesn't work. I opened home-assistant/home-assistant-js-websocket#64 to address that. Will update this in a future PR.
zsarnett
approved these changes
Oct 28, 2018
balloob
added a commit
that referenced
this pull request
Nov 2, 2018
* Handle no operation mode * Upgrade HAWS so we can use correct types * Lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type the climate entity component and handle the missed cases.
Fixes #1881
For domain specific cards, we should take the types from the docs. (and probably fill them in if they don't exist)