Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .js from imports #1948

Merged
merged 7 commits into from
Nov 2, 2018
Merged

Remove .js from imports #1948

merged 7 commits into from
Nov 2, 2018

Conversation

iantrich
Copy link
Member

@iantrich iantrich commented Nov 2, 2018

Also cleaned up some trailing whitespace

@iantrich
Remove .js from lovelace
de2d4bc 
Also cleaned up some trailing whitespace
@ghost ghost assigned iantrich Nov 2, 2018
@ghost ghost added the in progress label Nov 2, 2018
@iantrich iantrich changed the title Remove .js from lovelace Remove .js from imports Nov 2, 2018
@balloob
Copy link
Member

balloob commented Nov 2, 2018 •
edited
Loading

I merged something else and now we got merge conflicts…

@ghost ghost assigned balloob Nov 2, 2018
@balloob
Copy link
Member

balloob commented Nov 2, 2018

I just had a merge conflict because you changed a file hassio/webpack.config.js , only *.js and *.ts files in src, hassio/src and gallery/src should be updated

@balloob balloob merged commit c0c7c0f into home-assistant:dev Nov 2, 2018
@ghost ghost removed the in progress label Nov 2, 2018
@balloob balloob mentioned this pull request Nov 3, 2018
Merged
@iantrich iantrich deleted the remove-js-import branch November 16, 2018 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@iantrich iantrich

@balloob balloob

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iantrich @balloob @homeassistant