Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arm_custom_bypass #1911

Merged
merged 1 commit into from
Oct 29, 2018
Merged

add arm_custom_bypass #1911

merged 1 commit into from
Oct 29, 2018

Conversation

zsarnett
Copy link
Contributor

No description provided.

@ghost ghost assigned zsarnett Oct 29, 2018
@ghost ghost added the in progress label Oct 29, 2018
@zsarnett zsarnett merged commit 630214d into dev Oct 29, 2018
@ghost ghost removed the in progress label Oct 29, 2018
@balloob balloob deleted the add-bypass branch October 29, 2018 17:56
@c727
Copy link
Contributor

c727 commented Oct 29, 2018

@zsarnett
Copy link
Contributor Author

Can you explain why this is not correct and provide a solution? @c727

@balloob
Copy link
Member

balloob commented Oct 31, 2018

I think one is that we shouldn't add this under the ui key, All translations can use the state key.

We should have a fallback localize key either. The first one should just work.

@c727
Copy link
Contributor

c727 commented Oct 31, 2018

I guess you want to add a key for the mode/service arm_custom_bypass instead, it "works" cause it uses the state translation instead which can be similar/same. You should separate the localization of states and modes/services to avoid this. states[] is also a bad name for the service definition, maybe you should change it.

For static keys like clear_code you can use [[localize('ui.card.alarm_control_panel.clear_code')]].

@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants