Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes 5 #434

Merged
merged 69 commits into from
Jun 20, 2023
Merged

changes 5 #434

merged 69 commits into from
Jun 20, 2023

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Jun 13, 2023

Description

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.
  • All new dependency licenses have been checked for compatibility

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

cosa65 and others added 30 commits May 5, 2023 14:14
[BIOMAGE-2438] Make Subset feature work for Explorers
temporarily disable admin enforcement
…leted s3_data_key doesnt match any other existing plot
…what happened, and also whether the share did work or not
…the ones of the old ones. We use this sort() for shouldGem2sRerun(), so this determines whether the button will be go to data processing or not
cosa65 and others added 25 commits June 2, 2023 14:56
…that were not part of the action experimentController managed)
[87] Clone experiment with annotations
Signed-off-by: Alex Pickering <[email protected]>
Signed-off-by: Alex Pickering <[email protected]>
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #434 (3a21de0) into master (ff71634) will increase coverage by 0.09%.
The diff coverage is 84.55%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   90.83%   90.92%   +0.09%     
==========================================
  Files         155      155              
  Lines        3414     3484      +70     
  Branches      379      382       +3     
==========================================
+ Hits         3101     3168      +67     
- Misses        296      299       +3     
  Partials       17       17              
Impacted Files Coverage Δ
src/api.v2/controllers/gem2sController.js 100.00% <ø> (ø)
src/api.v2/helpers/roles.js 100.00% <ø> (ø)
.../helpers/worker/workSubmit/getExtraDependencies.js 100.00% <ø> (ø)
src/api.v2/middlewares/authMiddlewares.js 54.25% <ø> (-3.44%) ⬇️
src/api.v2/routes/experiment.js 93.33% <ø> (-6.67%) ⬇️
...api.v2/helpers/pipeline/pipelineConstruct/index.js 86.56% <42.85%> (+1.95%) ⬆️
...ne/pipelineConstruct/constructors/createNewStep.js 90.00% <50.00%> (-10.00%) ⬇️
src/api.v2/helpers/access/createUserInvite.js 92.00% <66.66%> (-8.00%) ⬇️
src/api.v2/helpers/pipeline/gem2s.js 96.96% <83.33%> (-0.91%) ⬇️
src/api.v2/constants.js 100.00% <100.00%> (ø)
... and 15 more

@alexvpickering alexvpickering merged commit 6977610 into master Jun 20, 2023
@alexvpickering alexvpickering deleted the biomage-changes-5 branch June 20, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants