[BIOMAGE-999] Add unit tests for the gem2s API point #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robioson
force-pushed
the
gem2s-test
branch
2 times, most recently
from
12ccddf to
bb1ddae
Compare
cosa65
reviewed
Jun 10, 2021
robioson
commented
Jun 10, 2021
cosa65
approved these changes
Jun 11, 2021
9 tasks
ivababukova
pushed a commit
that referenced
this pull request
Jul 19, 2021
* Add gem2s.test.js (modelled on pipeline.test.js) * Replace double with single quotes in spec * Improve coverage * Add test for invalid notification * Add test for gem2s pipeline creation * Reorder mocks * Avoid using stringify unnecessarily * Fix typos
alexvpickering
pushed a commit
that referenced
this pull request
Jun 12, 2023
Add share error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-999
Link to staging deployment URL
N/A
Links to any Pull Requests related to this
#109
Anything else the reviewers should know about the changes here
I initially based the tests on
pipelines.test.jssince the code forpipelines.jsis very similar to that ingem2s.js. I then added tests to get 100% coverage forgem2s.js. It could be worthwhile coming back and doing the same forpipelines.js.Changes
Code changes
tests/api/routes/gem2s.test.jssrc/api/route-services/__mocks__/experiment.jsDefinition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing
To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?
Approvers
Just before merging:
unstagescript in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to stagingOptional