Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem2s.test.js for new location of gem2sResponse #154

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

robioson
Copy link
Contributor

Background

Link to issue

Link to staging deployment URL

Links to any Pull Requests related to this

#150

Anything else the reviewers should know about the changes here

Prior to the above PR being merged, the location of gem2sResponse was changed on develop. This caused the tests to fail.

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@robioson robioson requested review from kafkasl, marcellp and cosa65 June 14, 2021 16:53
@robioson robioson merged commit b091dd1 into develop Jun 15, 2021
@robioson robioson deleted the gem2s-test-fix branch June 15, 2021 10:20
alexvpickering pushed a commit that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants