Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIOMAGE-1054] Pipeline flow does not follow the state machine definition #153

Merged
merged 6 commits into from
Jun 16, 2021

Conversation

marcellp
Copy link
Contributor

@marcellp marcellp commented Jun 14, 2021

Background

Link to issue

https://biomage.atlassian.net/browse/BIOMAGE-1054

Link to staging deployment URL

https://ui-marcellp-api153.scp-staging.biomage.net/experiments/marcellp-api153-e52b39624588791a7889e39c617f669e/data-processing

Links to any Pull Requests related to this

N/A

Anything else the reviewers should know about the changes here

N/A

Changes

Code changes

This should fix the issue. As the problem is related to requests from previous runs persisting and messing up the current run, the source is likely just AWS Step Functions activities being reused across runs, and they retain tasks until a success/failure message is sent. Even after a failure message is sent, it may still retain some of the tasks for a bit longer, but we don't know this for sure. Either way, making sure each pipeline run starts with an empty activity should be enough to fix the problem.

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@marcellp marcellp changed the title Pipeline flow does not follow the state machine definition [BIOMAGE-1054] Pipeline flow does not follow the state machine definition Jun 14, 2021
@marcellp
Copy link
Contributor Author

Copy link
Contributor

@aerlaut aerlaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested deleting a running container in staging via Lens, and the new container restarts from the beginning.

@marcellp marcellp merged commit ffcdb15 into develop Jun 16, 2021
@marcellp marcellp deleted the feature/fix-restarting-pipeline-in-middle branch June 16, 2021 11:12
ivababukova pushed a commit that referenced this pull request Jul 19, 2021
alexvpickering pushed a commit that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants