Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates failing and not detecting false value for node.config.gcfs_config.enabled #19482

Labels
bug forward/review In review; remove label to forward service/container

Comments

@wyardley
Copy link

wyardley commented Sep 14, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version & Provider Version(s)

OpenTofu v1.8.2
on darwin_arm64
+ provider registry.opentofu.org/hashicorp/google v6.1.0

Affected Resource(s)

google_container_cluster
google_container_node_pool

Terraform Configuration

Initial:

terraform {
  required_providers {
    google = {
      source  = "hashicorp/google"
      version = "6.1.0"
    }
  }
}
resource "google_container_cluster" "test_cfs_quota" {
  name               = "test-gcfs-config"
  location           = "us-central1-f"
  initial_node_count = 1

  deletion_protection = false
  network             = "default"
  subnetwork          = "default"
}

Subsequent:

terraform {
  required_providers {
    google = {
      source  = "hashicorp/google"
      version = "6.2.0"
    }
  }
}
resource "google_container_cluster" "test_cfs_quota" {
  name               = "test-gcfs-config"
  location           = "us-central1-f"
  initial_node_count = 1
  node_config {
    gcfs_config {
      enabled = false
    }
  }
  deletion_protection = false
  network             = "default"
  subnetwork          = "default"
}

Debug Output

Can provide if needed, basically, though, it's not actually trying to do the update.

Expected Behavior

No response

Actual Behavior

No response

Steps to reproduce

  1. terraform apply

Important Factoids

No response

References

GoogleCloudPlatform/magic-modules#11553
see also my comment here
GoogleCloudPlatform/magic-modules#11542

terraform-google-modules/terraform-google-kubernetes-engine#2100
terraform-google-modules/terraform-google-kubernetes-engine#2048

@wyardley wyardley added the bug label Sep 14, 2024
@github-actions github-actions bot added forward/review In review; remove label to forward service/container labels Sep 14, 2024
wyardley added a commit to wyardley/magic-modules that referenced this issue Sep 14, 2024
- Handle updates properly for `node_config.gcfs_config`
- Make `node_config.gcfs_config.enabled` optional and computed vs.
  required
- Add tests to make sure we test the case where it's defined in
  `google_container_cluster.node_config`, as well as testing updates for
  both that and the `google_container_node_pool` resource.

Fixes hashicorp/terraform-provider-google#19482
Follow up to GoogleCloudPlatform#11553
wyardley added a commit to wyardley/magic-modules that referenced this issue Sep 14, 2024
- Handle updates properly for `node_config.gcfs_config`
- Make `node_config.gcfs_config.enabled` optional and computed vs.
  required
- Add tests to make sure we test the case where it's defined in
  `google_container_cluster.node_config`, as well as testing updates for
  both that and the `google_container_node_pool` resource.

Fixes hashicorp/terraform-provider-google#19482
Follow up to GoogleCloudPlatform#11553
wyardley added a commit to wyardley/magic-modules that referenced this issue Sep 14, 2024
- Handle updates properly for `node_config.gcfs_config`
- Make `node_config.gcfs_config.enabled` optional and computed vs.
  required
- Add tests to make sure we test the case where it's defined in
  `google_container_cluster.node_config`, as well as testing updates for
  both that and the `google_container_node_pool` resource.

Fixes hashicorp/terraform-provider-google#19482
Follow up to GoogleCloudPlatform#11553
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.