-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates failing and not detecting false value for node.config.gcfs_config.enabled
#19482
Closed
wyardley opened this issue
Sep 14, 2024
· 1 comment
· Fixed by GoogleCloudPlatform/magic-modules#11717, #19512, hashicorp/terraform-provider-google-beta#8207 or GoogleCloudPlatform/terraform-google-conversion#2816
Closed
Updates failing and not detecting false value for node.config.gcfs_config.enabled
#19482
wyardley opened this issue
Sep 14, 2024
· 1 comment
· Fixed by GoogleCloudPlatform/magic-modules#11717, #19512, hashicorp/terraform-provider-google-beta#8207 or GoogleCloudPlatform/terraform-google-conversion#2816
Labels
Comments
github-actions
bot
added
forward/review
In review; remove label to forward
service/container
labels
Sep 14, 2024
This was referenced Sep 14, 2024
wyardley
added a commit
to wyardley/magic-modules
that referenced
this issue
Sep 14, 2024
- Handle updates properly for `node_config.gcfs_config` - Make `node_config.gcfs_config.enabled` optional and computed vs. required - Add tests to make sure we test the case where it's defined in `google_container_cluster.node_config`, as well as testing updates for both that and the `google_container_node_pool` resource. Fixes hashicorp/terraform-provider-google#19482 Follow up to GoogleCloudPlatform#11553
wyardley
added a commit
to wyardley/magic-modules
that referenced
this issue
Sep 14, 2024
- Handle updates properly for `node_config.gcfs_config` - Make `node_config.gcfs_config.enabled` optional and computed vs. required - Add tests to make sure we test the case where it's defined in `google_container_cluster.node_config`, as well as testing updates for both that and the `google_container_node_pool` resource. Fixes hashicorp/terraform-provider-google#19482 Follow up to GoogleCloudPlatform#11553
wyardley
added a commit
to wyardley/magic-modules
that referenced
this issue
Sep 14, 2024
- Handle updates properly for `node_config.gcfs_config` - Make `node_config.gcfs_config.enabled` optional and computed vs. required - Add tests to make sure we test the case where it's defined in `google_container_cluster.node_config`, as well as testing updates for both that and the `google_container_node_pool` resource. Fixes hashicorp/terraform-provider-google#19482 Follow up to GoogleCloudPlatform#11553
This was referenced Sep 17, 2024
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Community Note
Terraform Version & Provider Version(s)
Affected Resource(s)
google_container_cluster
google_container_node_pool
Terraform Configuration
Initial:
Subsequent:
Debug Output
Can provide if needed, basically, though, it's not actually trying to do the update.
Expected Behavior
No response
Actual Behavior
No response
Steps to reproduce
terraform apply
Important Factoids
No response
References
GoogleCloudPlatform/magic-modules#11553
see also my comment here
GoogleCloudPlatform/magic-modules#11542
terraform-google-modules/terraform-google-kubernetes-engine#2100
terraform-google-modules/terraform-google-kubernetes-engine#2048
The text was updated successfully, but these errors were encountered: