container: fix updates for node_config.gcfs_config
and make optional
#2816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes introduced a couple of issues with
node_config.gcfs_config
:node_config.gcfs_config
node_config.gcfs_config
optional and computedgoogle_container_cluster.node_config
, as well as testing updates for both that and thegoogle_container_node_pool
resource.Fixes hashicorp/terraform-provider-google#19482
Follow up to #11553
Possible fix for terraform-google-modules/terraform-google-kubernetes-engine#2100
Let me know if there are potential negative effects from having the only item in the block be optional and computed. I have tested creating a cluster with an empty
node_config.gcfs_config
block, as well as later enabling it from that state, so I don't think having it be optional and the only item within that nested block will be an issue.Might need to do a custom expand function or some more complicated code for the update case if more elements are added to the subblock, but this seems to work in my testing.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11717