feat: Remove force replacement from gcfs_config

[dominykasn]

Gcfsconfig changes do not require to re-create node pools hence there is no point to ForceNew on each gcfsconfig change, gcfs can be enabled and disabled via GUI or gcloud CLI without recreating node pools, examples:
https://cloud.google.com/kubernetes-engine/docs/how-to/image-streaming#disable

https://cloud.google.com/kubernetes-engine/docs/how-to/image-streaming#enable_on_node_pools

Also, same issue noted here hashicorp/terraform-provider-google#18417

Release Note Template for Downstream PRs (will be copied)

container: removed unnecessary force replacement in `gcfs_config`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[hao-nan-li]

I don't think contributor-membership-checker (graphite-docker-images) is part of the CI nowadays, could you rebase on main and re-commit?

[dominykasn]

Rebased and re-commited from main branch, however, I see other branches also have the same checks

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 43 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 2 files changed, 43 insertions(+), 29 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (376 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    gcfs_config {
      enabled = # value needed
    }
  }
  node_pool {
    node_config {
      gcfs_config {
        enabled = # value needed
      }
    }
  }
}

[hao-nan-li]

Rebased and re-commited from main branch, however, I see other branches also have the same checks

Thanks for the rebase, thanks for correcting, contributor-membership-checker is indeed part of the check, just that it no longer requires manual approval.

[modular-magician]

Tests analytics

Total tests: 200
Passed tests: 186
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_gcfsConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_gcfsConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 44 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 2 files changed, 44 insertions(+), 30 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (383 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    gcfs_config {
      enabled = # value needed
    }
  }
  node_pool {
    node_config {
      gcfs_config {
        enabled = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 203
Passed tests: 189
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_gcfsConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_gcfsConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[wyardley]

Similar note to: #11541 (review) - it may be worth adding the suggested test of this parameter when it's used in resource "google_container_cluster", and specifically testing updates as well. It's a known issue that many of these parameters don't actually support updating when called this way.

[dominykasn]

Sure, will check, however, is there a possibility to check why my tests are failing?

[dominykasn]

Also, please correct me if I'm wrong but there are already tests written here for cluster and gcfs config changes?

[github-actions]

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[wyardley]

Oh yeah, looks like it!

[dominykasn]

What do I need to do more in this case for this to get approved? 🤔

[hao-nan-li]

What do I need to do more in this case for this to get approved? 🤔

I think the VCR test needs to be fixed. resource_container_node_pool_test.go:1707: Step 3/4 error: Check failed: Check 1/1 error: google_container_node_pool.np: Attribute 'node_config.0.gcfs_config.0.enabled' expected "false", got "true"

[wyardley]

Also, please correct me if I'm wrong but there are already tests written here for cluster and gcfs config changes?

[Just to be clear, I'm not a Google employee, and am not reviewing this PR, just was commenting in case it's helpful since I did some work around similar changes recently.]

Reading those a bit more carefully, from what I can see, that's only testing the setting within node_pool_defaults.node_config_defaults, which influence the default behavior of newly created node pools. This only requires a cluster update to be performed.
The comment is also requesting a test for node_config.gcfs_config (this is the config for default-pool if created implicitly when created directly within the google_container_cluster resource), which I don't think is tested anywhere.

My prediction is that if you add or extend the test to test node_config.gcfs_config, it will fail, because I don't think there's anything related to gcfs_config here.

That is more complicated to update, and as yet only implemented for one or two parameters. See hashicorp/terraform-provider-google#19225 for a high level description of the issue, and some of the comments in #11272 for more context

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 46 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 3 files changed, 47 insertions(+), 33 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (386 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    gcfs_config {
      enabled = # value needed
    }
  }
  node_pool {
    node_config {
      gcfs_config {
        enabled = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 204
Passed tests: 190
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_gcfsConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_gcfsConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 34 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 3 files changed, 35 insertions(+), 33 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (385 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    gcfs_config {
      enabled = # value needed
    }
  }
  node_pool {
    node_config {
      gcfs_config {
        enabled = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 204
Passed tests: 191
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages

• container

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log