Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container - add hugepages config #11541

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Aug 24, 2024

Closes hashicorp/terraform-provider-google#16497

tested locally:

--- PASS: TestAccContainerNodePool_withHugepageConfig (817.36s)

Release Note Template for Downstream PRs (will be copied)

container: added `hugepages_config` in `linux_node_config` in `google_container_node_pool` resource

@github-actions github-actions bot requested a review from melinath August 24, 2024 22:36
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 24, 2024
Copy link

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from Google, but just pointing out one minor thing in the test.

Only other thought: if this is valid in google_container_cluster.node_config as well (which I think it is), that should probably have a separate update test; also, I noticed with #11272 at least, that updating the default nodepool when used in that context isn't always setup properly.

May be slightly different for this one, but I had to add some changes in here for that to work (assuming either the nodepool or the cluster needs to get updated there).

@melinath melinath requested review from a team and slevenick and removed request for melinath and a team August 29, 2024 22:38
@melinath
Copy link
Member

Apologies for the delayed review - reassigning since I'll be OOO tomorrow.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 29, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 143 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 143 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (387 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      hugepages_config {
        hugepage_size_1g = # value needed
        hugepage_size_2m = # value needed
      }
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        hugepages_config {
          hugepage_size_1g = # value needed
          hugepage_size_2m = # value needed
        }
      }
    }
  }
}

Resource: google_container_node_pool (74 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      hugepages_config {
        hugepage_size_1g = # value needed
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 205
Passed tests: 191
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerNodePool_withHugepageConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withHugepageConfig[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link

github-actions bot commented Sep 3, 2024

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Sep 5, 2024

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update test doesn't seem to do anything. Please fix so that the config changes

@github-actions github-actions bot requested a review from slevenick September 6, 2024 21:56
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 6, 2024
@DrFaust92
Copy link
Contributor Author

thanks slevenick, added + covered second param in that block as well

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 9, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 144 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 144 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (387 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      hugepages_config {
        hugepage_size_1g = # value needed
        hugepage_size_2m = # value needed
      }
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        hugepages_config {
          hugepage_size_1g = # value needed
          hugepage_size_2m = # value needed
        }
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 205
Passed tests: 191
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerNodePool_withHugepageConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withHugepageConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing with:
Error: Invalid expression

      on terraform_plugin_test.tf line 26, in resource "google_container_node_pool" "np":
      26: 	    hugepage_size_1g = %!d(MISSING)

Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92
Copy link
Contributor Author

thanks slevenick, fixed + tested properly

Signed-off-by: drfaust92 <[email protected]>
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 17, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 145 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 145 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (394 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      hugepages_config {
        hugepage_size_1g = # value needed
        hugepage_size_2m = # value needed
      }
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        hugepages_config {
          hugepage_size_1g = # value needed
          hugepage_size_2m = # value needed
        }
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 211
Passed tests: 197
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerNodePool_withHugepageConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withHugepageConfig[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@slevenick slevenick merged commit 3c1625c into GoogleCloudPlatform:main Sep 18, 2024
12 checks passed
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Huge Page configuration on node pool
5 participants