-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container - add hugepages config #11541
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not from Google, but just pointing out one minor thing in the test.
Only other thought: if this is valid in google_container_cluster.node_config
as well (which I think it is), that should probably have a separate update test; also, I noticed with #11272 at least, that updating the default nodepool when used in that context isn't always setup properly.
May be slightly different for this one, but I had to add some changes in here for that to work (assuming either the nodepool or the cluster needs to get updated there).
mmv1/third_party/terraform/services/container/resource_container_node_pool_test.go.erb
Outdated
Show resolved
Hide resolved
Apologies for the delayed review - reassigning since I'll be OOO tomorrow. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_config {
linux_node_config {
hugepages_config {
hugepage_size_1g = # value needed
hugepage_size_2m = # value needed
}
}
}
node_pool {
node_config {
linux_node_config {
hugepages_config {
hugepage_size_1g = # value needed
hugepage_size_2m = # value needed
}
}
}
}
}
Resource: resource "google_container_node_pool" "primary" {
node_config {
linux_node_config {
hugepages_config {
hugepage_size_1g = # value needed
}
}
}
}
|
Tests analyticsTotal tests: 205 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update test doesn't seem to do anything. Please fix so that the config changes
thanks slevenick, added + covered second param in that block as well |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_config {
linux_node_config {
hugepages_config {
hugepage_size_1g = # value needed
hugepage_size_2m = # value needed
}
}
}
node_pool {
node_config {
linux_node_config {
hugepages_config {
hugepage_size_1g = # value needed
hugepage_size_2m = # value needed
}
}
}
}
}
|
Tests analyticsTotal tests: 205 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing with:
Error: Invalid expression
on terraform_plugin_test.tf line 26, in resource "google_container_node_pool" "np":
26: hugepage_size_1g = %!d(MISSING)
…er_node_pool_test.go.erb Co-authored-by: Will Yardley <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
ad8e966
to
1ab3c6a
Compare
thanks slevenick, fixed + tested properly |
Signed-off-by: drfaust92 <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_config {
linux_node_config {
hugepages_config {
hugepage_size_1g = # value needed
hugepage_size_2m = # value needed
}
}
}
node_pool {
node_config {
linux_node_config {
hugepages_config {
hugepage_size_1g = # value needed
hugepage_size_2m = # value needed
}
}
}
}
}
|
Tests analyticsTotal tests: 211 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: drfaust92 <[email protected]> Co-authored-by: Will Yardley <[email protected]>
Signed-off-by: drfaust92 <[email protected]> Co-authored-by: Will Yardley <[email protected]>
Signed-off-by: drfaust92 <[email protected]> Co-authored-by: Will Yardley <[email protected]>
Closes hashicorp/terraform-provider-google#16497
tested locally:
Release Note Template for Downstream PRs (will be copied)