-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container: bump gcsfs to GA #11542
container: bump gcsfs to GA #11542
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 200 Click here to see the affected service packages
Tests were added that are GA-only additions and require manual runs:
View the build log |
Side note: it's merged now, though there are now some conflicts. |
thanks wyardley, fixed |
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
One thing I'm noticing when looking at hashicorp/terraform-provider-google#19482 |
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 3 weeks. Please take a look! Use the label |
Signed-off-by: drfaust92 <[email protected]>
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 4 weeks. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 212 Click here to see the affected service packages
Tests were added that are GA-only additions and require manual runs:
View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving after running tests on PR through TeamCity: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CONTAINER/239420?buildTab=tests&expandedTest=build%3A%28id%3A239420%29%2Cid%3A2000000000
------- Stdout: -------
=== RUN TestAccContainerCluster_withNodePoolDefaults
=== PAUSE TestAccContainerCluster_withNodePoolDefaults
=== CONT TestAccContainerCluster_withNodePoolDefaults
--- PASS: TestAccContainerCluster_withNodePoolDefaults (979.00s)
PASS
Thanks for this!
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Release Note Template for Downstream PRs (will be copied)