-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E: TestNodeDrainEphermeralMigrate
should work with client ACLs
#12314
Comments
Noting that as of #16530 we do have client ACLs enabled, so this test is failing. I'll get this fixed as part of a set of work I'm doing over the next couple weeks about drains. |
Example error on the client:
It turns out the problem with our test is that we don't have |
Our E2E environment doesn't have
acls { enabled = true }
on the clients, just the servers. If this setting is enabled, theTestNodeDrainEphermeralMigrate
fails because the client-to-client ACL check fails and the data isn't migrated. We need to figure out the right client ACL policy to support this. This predates #12267 but I noticed it while working on it.Note that failure happens silently. The old allocation is simply stopped and the data isn't migrated and the user isn't warned of this, because ephemeral disk migration is best effort. #12267 includes a commit to make the test failure more legible in this case.
The text was updated successfully, but these errors were encountered: