Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drain is marked complete well before it's actually complete #12915

Closed
josh-m-sharpe opened this issue May 6, 2022 · 3 comments · Fixed by #14348
Closed

drain is marked complete well before it's actually complete #12915

josh-m-sharpe opened this issue May 6, 2022 · 3 comments · Fixed by #14348
Assignees
@tgross
Labels
theme/drain type/bug
Milestone
1.5.x

Comments

@josh-m-sharpe
Copy link

josh-m-sharpe commented May 6, 2022 •
edited
Loading

Is this expected? Or maybe I have something misconfigured.

Steps to repro:

  1. Have new empty client ready to go
  2. Click "Drain" on client full of jobs
  3. shows "Drain Complete' almost immediately
  4. Look at topology and see new client still spinning up allocs

Client_ip-10-20-21-68_us-west-2_compute_internal_-Nomad_and_Cluster_Topology-_Nomad
@DerekStrickland DerekStrickland self-assigned this May 9, 2022
@DerekStrickland DerekStrickland removed their assignment May 13, 2022
@tgross
Copy link
Member

tgross commented Jun 6, 2022

Hi @josh-m-sharpe! The API is most likely returning the right response here; the CLI runs a monitor that waits until the drain is complete. So this looks like the UI may be marking the completion a bit too eagerly. I'm going to mark this so that our UI folks can take a look. Thanks!

@tgross tgross added this to Nomad UI Jun 6, 2022
@tgross tgross moved this to Icebox in Nomad UI Jun 6, 2022
@tgross tgross moved this from Icebox to Todo in Nomad UI Jun 6, 2022
@tgross tgross added the theme/ui label Jun 6, 2022
@ChaiWithJai ChaiWithJai moved this from Todo to In Progress in Nomad UI Aug 15, 2022
@ChaiWithJai ChaiWithJai self-assigned this Aug 15, 2022
@srisch srisch mentioned this issue Aug 24, 2022
Closed
@tgross tgross assigned tgross and unassigned ChaiWithJai Aug 25, 2022
@tgross tgross removed the theme/ui label Aug 25, 2022
@tgross
Copy link
Member

tgross commented Aug 25, 2022

I'm working up some notes now, but it looks like as part of my investigation into #14293 that this is not a UI bug after all, but the DrainStrategy field is getting reset prematurely.

@tgross tgross mentioned this issue Aug 26, 2022
Merged
@tgross tgross linked a pull request Aug 26, 2022 that will close this issue
drain: use client status to determine drain is complete #14348
Merged
@tgross tgross removed this from Nomad UI Aug 26, 2022
@tgross tgross added this to the 1.3.x milestone Aug 26, 2022
@tgross tgross modified the milestones: 1.3.x, 1.4.x Aug 30, 2022
@tgross tgross removed this from the 1.4.x milestone Jan 20, 2023
@tgross tgross mentioned this issue Feb 13, 2023
Open
@tgross tgross mentioned this issue Apr 6, 2023
Merged
tgross added a commit that referenced this issue Apr 7, 2023
@tgross
E2E: update subset of node drain tests off the old framework
55e615d 
While working on several open drain issues, I'm fixing up the E2E tests. This
subset of tests being refactored are existing ones that already work. I'm
shipping these as their own PR to keep review sizes manageable when I push up
PRs in the next few days for #9902, #12314, and #12915.
tgross added a commit that referenced this issue Apr 7, 2023
@tgross
E2E: update subset of node drain tests off the old framework (#16823)
bca03b6 
While working on several open drain issues, I'm fixing up the E2E tests. This
subset of tests being refactored are existing ones that already work. I'm
shipping these as their own PR to keep review sizes manageable when I push up
PRs in the next few days for #9902, #12314, and #12915.
tgross added a commit that referenced this issue Apr 12, 2023
@tgross
E2E: update subset of node drain tests off the old framework (#16823)
c9d1fc0 
While working on several open drain issues, I'm fixing up the E2E tests. This
subset of tests being refactored are existing ones that already work. I'm
shipping these as their own PR to keep review sizes manageable when I push up
PRs in the next few days for #9902, #12314, and #12915.
tgross added a commit that referenced this issue Apr 12, 2023
@tgross
E2E: update subset of node drain tests off the old framework (#16823)
a0d2c42 
While working on several open drain issues, I'm fixing up the E2E tests. This
subset of tests being refactored are existing ones that already work. I'm
shipping these as their own PR to keep review sizes manageable when I push up
PRs in the next few days for #9902, #12314, and #12915.
tgross added a commit that referenced this issue Apr 12, 2023
@tgross
E2E: update subset of node drain tests off the old framework (#16823)
3aad802 
While working on several open drain issues, I'm fixing up the E2E tests. This
subset of tests being refactored are existing ones that already work. I'm
shipping these as their own PR to keep review sizes manageable when I push up
PRs in the next few days for #9902, #12314, and #12915.
This was referenced Apr 13, 2023
Merged
Merged
Merged
@tgross tgross added this to the 1.5.x milestone Apr 13, 2023
@tgross
Copy link
Member

tgross commented Apr 13, 2023

This issue is fixed by #14348, which will ship in the next regular patch release of Nomad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgross tgross

Labels
theme/drain type/bug
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
1.5.x
Development

Successfully merging a pull request may close this issue.

drain: use client status to determine drain is complete hashicorp/nomad
4 participants
@josh-m-sharpe @DerekStrickland @tgross @ChaiWithJai