-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E with HCP Consul/Vault #12267
E2E with HCP Consul/Vault #12267
Conversation
The cluster has a unique name per run, so scrape the whole set. We can't reach any other cluster, so we'll only get metrics for our own.
* split out to its own suite * skip tests that require `consul.allow_unauthenticated = false` for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! My only real question is about the file permissions and maybe the consul user.
Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great working getting this done 🎉
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Use HCP Consul and HCP Vault for the Consul and Vault clusters used in E2E testing. This has the following benefits:
provision.sh
/provision.ps1
scripts we were using previously. We can template Nomad configuration files and upload them with thefile
provisioner.tl;dr way less janky shell scripting!
At this point I've tested out most of the E2E suite with this configuration, in particular the
Connect
andVaultSecrets
suite that are the most likely to break. I still need to complete full testing. There was a parallel PR merged in thenomad-e2e
repo to set up the infrastructure.Follow-up issues:
TestNodeDrainEphermeralMigrate
should work with client ACLs #12314consul.allow_unauthenticated = false
on Nomad config #12315There will be a PR in the ENT repo for the ENT-only Consul namespaces test as well.
Tests passing against a current build of
main
from the Nomad ENT repo (plus a couple patches from this PR):