Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E with HCP Consul/Vault #12267

Merged
merged 19 commits into from
Mar 18, 2022
Merged

E2E with HCP Consul/Vault #12267

merged 19 commits into from
Mar 18, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 11, 2022

Use HCP Consul and HCP Vault for the Consul and Vault clusters used in E2E testing. This has the following benefits:

  • Without the need to support mTLS bootstrapping for Consul and Vault, we can simplify the mTLS configuration by leaning on Terraform instead of janky bash shell scripting.
  • Vault bootstrapping is no longer required, so we can eliminate even more janky shell scripting
  • Our E2E exercises HCP, which is important to us as an organization
  • With the reduction in configurability, we can simplify the Terraform configuration and drop the complicated provision.sh/provision.ps1 scripts we were using previously. We can template Nomad configuration files and upload them with the file provisioner.
  • Packer builds for Linux and Windows become much simpler.

tl;dr way less janky shell scripting!

At this point I've tested out most of the E2E suite with this configuration, in particular the Connect and VaultSecrets suite that are the most likely to break. I still need to complete full testing. There was a parallel PR merged in the nomad-e2e repo to set up the infrastructure.

Follow-up issues:

There will be a PR in the ENT repo for the ENT-only Consul namespaces test as well.

Tests passing against a current build of main from the Nomad ENT repo (plus a couple patches from this PR):

  • affinities
  • connect/Connect
  • connect/ConnectACLs
  • consul/Consul
  • consul/ConsulNamespaces
  • consultemplate
  • csi
  • deployment
  • eval_priority
  • events
  • simple
  • isolation
  • lifecycle
  • metrics
  • namespaces
  • networking
  • nodedrain
  • nomadexec
  • oversubscription
  • parameterized
  • periodic
  • quotas
  • rescheduling
  • scaling
  • scalingpolicies
  • scheduler_sysbatch
  • scheduler_system
  • spread
  • taskevents
  • vaultsecrets
  • volumes

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 11, 2022

CLA assistant check
All committers have signed the CLA.

tgross added 3 commits March 17, 2022 11:24
The cluster has a unique name per run, so scrape the whole set. We
can't reach any other cluster, so we'll only get metrics for our own.
tgross added 2 commits March 17, 2022 11:51
* split out to its own suite
* skip tests that require `consul.allow_unauthenticated = false` for now
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My only real question is about the file permissions and maybe the consul user.

Thanks for doing this!

e2e/connect/acls.go Outdated Show resolved Hide resolved
e2e/connect/acls.go Outdated Show resolved Hide resolved
e2e/connect/acls.go Outdated Show resolved Hide resolved
e2e/terraform/README.md Outdated Show resolved Hide resolved
e2e/terraform/etc/consul.d/consul.service Outdated Show resolved Hide resolved
e2e/terraform/hcp_consul.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great working getting this done 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants