Hide the hcp link banner behind an env variable #20392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-hut
added
theme/ui
WenInCode
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
You may want to add the env var stuff to get-environment so that you can disable it with Scenario('name=0') like all the other envvars.
If you do you should update it to be that fun ENABLE vs ENABLED
But also not necessary and I probably wouldn't do that given you will be tearing this out after the RC release.
valeriia-ruban
approved these changes
Jan 29, 2024
4 tasks
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the 1.18 RC release getting cut tomorrow, we want to hide the HCP link banner - as it won't be done until the 1.18.0 release.
Testing & Reproduction steps
Scenario('CONSUL_HCP_LINK_ENABLED=true')and see the banner exists nowLinks
References