Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chor: remove temporary CONSUL_HCP_LINK_ENABLED env flag #1063

Open
4 tasks
dhiaayachi opened this issue Sep 27, 2024 · 0 comments
Open
4 tasks

chor: remove temporary CONSUL_HCP_LINK_ENABLED env flag #1063

dhiaayachi opened this issue Sep 27, 2024 · 0 comments

Comments

@dhiaayachi
Copy link
Owner

Description

Remove temporary CONSUL_HCP_LINK_ENABLED env flag.
PR it was added: hashicorp#20392

Testing & Reproduction steps

  1. go to consul
  2. go to Service list - link to HCP banner is visible
  3. set CONSUL_HCP_LINK_ENABLED to true and then to false (from cookies or with running locally Scenario('CONSUL_HCP_LINK_ENABLED=true')) - banner is still there for any value

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhiaayachi