Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert link existing but better 🪦 #785

Open
dhiaayachi opened this issue Sep 26, 2024 · 0 comments
Open

Revert link existing but better 🪦 #785

dhiaayachi opened this issue Sep 26, 2024 · 0 comments

Comments

@dhiaayachi
Copy link
Owner

Description

Now that we're removing all of the link existing but better (hashicorp#20732), let's remove all of this code, to hopefully leave the campground a bit cleaner than it would've been!

I've decided to not backport this to 1.18.X - as that branch can live on with everything hardcoded off, but would prefer to clean up main. Happy to discuss though, and possibly backport this there if needed!

Testing & Reproduction steps

The majority of this feature had entry points on the Services tab, so check there for any mention of Linking a cluster, ideally should look like:

image

Date Pr Reverted
Feb 21st [Add alert to link to HCP modal] (hashicorp#20682)
Feb 15th Change cluster name param to datacenter.name
Feb 13th Add info error message when acls disabled
Feb 9th Link to HCP Modal
Feb 1st Add nav bar item to show HCP link status
Jan 29th Hide the HCP Link Banner behind env variable
Jan 29th Fix UI Tests
Jan 26th Convert Consul HCP to simpler component
Jan 26th HCP Link status api
Jan 23rd Purple Banner

The three PRs I haven't reverted here are because:

  • Hide the HCP Link Banner behind env was reverted previously
  • Fix UI Tests - the tests are removed 🤔
  • Conver Consul HCP to simpler component - this is a nice cleanup we'll still want

References

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant