chor: change cluster name param to have datacenter.name as default value #20644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-hut
approved these changes
Feb 14, 2024
valeriia-ruban
added
backport/1.18
pr/no-changelog
valeriia-ruban
deleted the
change-from-api-returned-cluster-name-to-data-center-name-on-link-to-hcp
branch
4 tasks
chris-hut
added a commit
that referenced
this pull request
Mar 13, 2024
* Revert "feat: add alert to link to hcp modal to ask a user refresh a page; up… (#20682)" This reverts commit dd833d9. * Revert "chor: change cluster name param to have datacenter.name as default value (#20644)" This reverts commit 8425cd0. * Revert "chor: adds informative error message when acls disabled and read-only… (#20600)" This reverts commit 9d712cc. * Revert "Cc 7147 link to hcp modal (#20474)" This reverts commit 8c05e57. * Revert "Add nav bar item to show HCP link status and encourage folks to link (#20370)" This reverts commit 22e6ce0. * Revert "Cc 7145 hcp link status api (#20330)" This reverts commit 049ca10. * Revert "💜 Cc 7187/purple banner for linking existing clusters (#20275)" This reverts commit 5119667.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rethink on default value for cluster name on linking.
With the pr it is set to datacenter name
Attention to link ⬇️
Testing & Reproduction steps
Links
PR Checklist