-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert link existing but better 🪦 #20830
Merged
The head ref may contain hidden characters: "revert-link-existing-but-better-\u{1FAA6}"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-hut
added
pr/no-backport
pr/no-changelog
PR does not need a corresponding .changelog entry
and removed
theme/ui
Anything related to the UI
labels
Mar 11, 2024
valeriia-ruban
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the description! 😍
Massive work, tested locally and it looks good for me!
…xisting-but-better-🪦
…orp/consul into revert-link-existing-but-better-🪦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we're removing all of the link existing but better (#20732), let's remove all of this code, to hopefully leave the campground a bit cleaner than it would've been!
I've decided to not backport this to 1.18.X - as that branch can live on with everything hardcoded off, but would prefer to clean up main. Happy to discuss though, and possibly backport this there if needed!
Testing & Reproduction steps
The majority of this feature had entry points on the Services tab, so check there for any mention of Linking a cluster, ideally should look like:
The three PRs I haven't reverted here are because:
References