Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert link existing but better 🪦 #20830

Merged
merged 10 commits into from
Mar 13, 2024
Merged

Conversation

chris-hut
Copy link
Contributor

@chris-hut chris-hut commented Mar 11, 2024

Description

Now that we're removing all of the link existing but better (#20732), let's remove all of this code, to hopefully leave the campground a bit cleaner than it would've been!

I've decided to not backport this to 1.18.X - as that branch can live on with everything hardcoded off, but would prefer to clean up main. Happy to discuss though, and possibly backport this there if needed!

Testing & Reproduction steps

The majority of this feature had entry points on the Services tab, so check there for any mention of Linking a cluster, ideally should look like:

image

Date Pr Reverted
Feb 21st [Add alert to link to HCP modal] (#20682)
Feb 15th Change cluster name param to datacenter.name
Feb 13th Add info error message when acls disabled
Feb 9th Link to HCP Modal
Feb 1st Add nav bar item to show HCP link status
Jan 29th Hide the HCP Link Banner behind env variable
Jan 29th Fix UI Tests
Jan 26th Convert Consul HCP to simpler component
Jan 26th HCP Link status api
Jan 23rd Purple Banner

The three PRs I haven't reverted here are because:

  • Hide the HCP Link Banner behind env was reverted previously
  • Fix UI Tests - the tests are removed 🤔
  • Conver Consul HCP to simpler component - this is a nice cleanup we'll still want

References

image

@github-actions github-actions bot added the theme/ui Anything related to the UI label Mar 11, 2024
@chris-hut chris-hut added pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry and removed theme/ui Anything related to the UI labels Mar 11, 2024
Copy link
Contributor

@valeriia-ruban valeriia-ruban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the description! 😍
Massive work, tested locally and it looks good for me!

@chris-hut chris-hut marked this pull request as ready for review March 13, 2024 17:52
@chris-hut chris-hut merged commit bfbc0ee into main Mar 13, 2024
84 of 85 checks passed
@chris-hut chris-hut deleted the revert-link-existing-but-better-🪦 branch March 13, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants