Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Capitalization of "Slack" in CONTRIBUTING.MD #7038

Merged

Conversation

dcotelessa
Copy link
Member

@dcotelessa dcotelessa commented Jun 19, 2024

Fixes #6932

What changes did you make?

  • capitalize slack to Slack on line 582 of CONTRIBUTING.md
  • Do not change any other lines in the file.
  • Reviewed changes on URL below

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website

  • No visual changes on the website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/dcotelessa/website/blob/fix-capitalization-slack-6932/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers Feature: Onboarding/Contributing.md Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Jun 19, 2024
@buneeIsSlo buneeIsSlo self-requested a review June 20, 2024 07:24
@buneeIsSlo
Copy link
Member

Review ETA: e.o.d
Availability: 5 pm - 10 pm Weekdays

Copy link
Member

@buneeIsSlo buneeIsSlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dcotelessa Great job!

  • The branches from and to are setup correctly
  • The original issue is linked correctly
  • There is a clear and succinct description of what was done
  • Changes made do not affect the website
  • Extra points for adding a note for reviewers

Great work again, and thanks for working on this issue!

@jchue jchue self-requested a review June 22, 2024 17:54
@jchue
Copy link
Member

jchue commented Jun 22, 2024

  • ETA: EOD
  • Availability: After 5 PM PDT weekdays

Copy link
Member

@jchue jchue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @dcotelessa, well done.

  • Branching is correct
  • Correctly linked issue
  • Markdown file updated correctly
  • Slack URL unchanged

@drakenguyen4000 drakenguyen4000 merged commit b9b1caa into hackforla:gh-pages Jun 23, 2024
12 checks passed
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 5, 2024
t-will-gillis added a commit that referenced this pull request Aug 18, 2024
)

* updated-team-meeting-data-6920

* Update contributor and language data

* Update contributor and language data

* Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038)

* Update contributor and language data

* Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036)

* PBB migration "Issue Trigger"  (#7053)

* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration

* PBB migration "Pull Request Trigger" (#7054)

* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch

* PBB migration "Schedule Friday" (#7055)

* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert

* PBB migration "Move Closed Issues" (#7056)

* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js

* Add github-handle for Roland Abregorivas in heart.md #6940 (#7009)

* github-handle variable added for Gian Reyes Dionisio #6937 (#6984)

* Update contributor and language data

* updated role for Will Gillis on website project profile (#7063)

* Add github handle for Marie (#7059)

* added github handle element for Tien Yuan in heart.md (#7069)

* Update contributor and language data

* Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

* Update Roslyn's role to Developer Co-Lead (#7070)

* img Tag Refactor in Contributing.md page  (#7068)

* Update contributor and language data

* Added github-handle to Adrian Inchauste's section (#7074)

* Update contributor and language data

* edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040)

* 6786 remove bop from untaggedrepoids in get project datajs (#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <[email protected]>

* Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082)

* Update meeting data

* Update contributor and language data

* Update Inactive Members JSON

* Revert "updated-team-meeting-data-6920 (#7043)" (#7086)

This reverts commit dc11c65.

* Update contributor and language data

* Update contributor and language data

* updated team meeting data on events page to show meeting frequency

* Add 'Leadership Option' to Issue Template for CoP Information Update (#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type

* Update contributor and language data

* Updated spell checker to ignore memebers names (#7073)

* Update contributor and language data

* Update contributor and language data

* truncate contributors name in filter tag with ellipis (#7052)

* Update contributor and language data

---------

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: David Cotelessa <[email protected]>
Co-authored-by: Santiago Secco <[email protected]>
Co-authored-by: Will Gillis <[email protected]>
Co-authored-by: Jennifer Sung <[email protected]>
Co-authored-by: williamzhang <[email protected]>
Co-authored-by: Melissa McGrath <[email protected]>
Co-authored-by: Austin Labador <[email protected]>
Co-authored-by: Matthew McCane <[email protected]>
Co-authored-by: Kim <[email protected]>
Co-authored-by: Christopher Chang <[email protected]>
Co-authored-by: duojet2ez <[email protected]>
Co-authored-by: Mateo Rodriguez <[email protected]>
Co-authored-by: Danielle Andrews <[email protected]>
Co-authored-by: vanessasinam <[email protected]>
Co-authored-by: Aadil Ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Capitalization of "Slack" in CONTRIBUTING.MD
4 participants