Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Capitalization of "Slack" in CONTRIBUTING.MD #6932

Closed
4 of 5 tasks
Tracked by #6844
del9ra opened this issue Jun 3, 2024 · 2 comments · Fixed by #7038
Closed
4 of 5 tasks
Tracked by #6844

Fix Capitalization of "Slack" in CONTRIBUTING.MD #6932

del9ra opened this issue Jun 3, 2024 · 2 comments · Fixed by #7038
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@del9ra
Copy link
Member

del9ra commented Jun 3, 2024

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started Page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to fix the following line of code to correctly capitalize "Slack" when it's used to refer to the app or the company in our code and content.

  • - If you still do not see your changes after trying these steps, please feel free to reach out to the team in the [#hfla-site](https://hackforla.slack.com/archives/C4UM52W93) slack channel, or bring up your issue in a dev meeting.

Action Items

  • Open the file CONTRIBUTING.MD in your code editor
  • On Line 582 replace every slack with Slack when it's used to refer to the app and the company, do not make changes within URLs. Do not change any other lines in the file.
  • Changes to CONTRIBUTING.md should not be tested locally, rather they need to be tested after pushing the issue branch to your fork of the repository. Push your issue branch in the usual manner, but before creating the Pull Request, check your updates using this test URL. Also store the test URL for use in a later step:
https://github.com/[REPLACE WITH GITHUB HANDLE]/website/blob/[REPLACE WITH NAME OF ISSUE BRANCH]/CONTRIBUTING.md

(for example: https://github.com/bonniewolfe/website/blob/issue-branch-1234/CONTRIBUTING.md)

  • Create a pull request with your changes. In the Pull Request, after the "Why did you make the changes" section, add this line to help reviewers, replacing the text in brackets (and the brackets) with the test URL from the previous Action Item.
For Reviewers: Do not review changes locally, rather, review changes at [REPLACE WITH TEST URL]

For Merge Team

Resources/Instructions

This issue is part of Issue Making Issue #6844 and ER #6163.

@del9ra del9ra added role: front end Tasks for front end developers Feature: Onboarding/Contributing.md Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization labels Jun 3, 2024
@ExperimentsInHonesty ExperimentsInHonesty added this to the 08. Team workflow milestone Jun 8, 2024
@Thinking-Panda Thinking-Panda added Ready for Prioritization and removed ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization labels Jun 11, 2024
@dcotelessa dcotelessa self-assigned this Jun 19, 2024
Copy link

Hi @dcotelessa, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@dcotelessa
Copy link
Member

ETA: 15 min
Availability: Fri: 10-5pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

4 participants