Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change label in spell check issue template #7036

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Change label in spell check issue template #7036

merged 4 commits into from
Jun 23, 2024

Conversation

santisecco
Copy link
Member

Fixes #6857

What changes did you make?

  • I changed the label 'Feature: Administrative' to 'feature: spelling' in the file spell-check-audit.md that works as template for the issues "Run VS Code Spell Checker on [INSERT FILE HERE]"

Why did you make the changes (we will use this info to test)?

  • So the issues generated from the above mentioned template are properly labeled.

For Reviewers

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b santisecco-change-label-spellcheck-6857 gh-pages
git pull https://github.com/santisecco/website.git change-label-spellcheck-6857

@github-actions github-actions bot added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium size: 1pt Can be done in 4-6 hours feature: spelling role: back end labels Jun 19, 2024
@santisecco santisecco requested a review from t-will-gillis June 20, 2024 17:24
t-will-gillis
t-will-gillis approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @santisecco - Everything looks good- branches are correct, there is a link back to the original issue, there are descriptions of what was changed and why, there is a link demonstrating the template form has the new labelling, there are no changes to the website, and the code edits are clean.

Great job and thanks for working on this!

@t-will-gillis t-will-gillis merged commit f557f73 into hackforla:gh-pages Jun 23, 2024
10 checks passed
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 5, 2024
@santisecco @terrencejihoonjung
Modified spell-check-audit.md file, changed label Feature: Administra…
17f5b38 
…tive to feature: spelling (hackforla#7036)
t-will-gillis added a commit that referenced this pull request Aug 18, 2024
@terrencejihoonjung @HackforLABot
@dcotelessa @santisecco @t-will-gillis @jennisung @williamzhang73 @melissam640 @alabador @DakuwoN @Kle012 @cchrizzle @duojet2ez @mrodz @DrAcula27 @vanessasinam @aadilahmed
Update Team Meeting Data on Events Page to show Meeting Frequency (#7088
5cb891d 
)

* updated-team-meeting-data-6920

* Update contributor and language data

* Update contributor and language data

* Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038)

* Update contributor and language data

* Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036)

* PBB migration "Issue Trigger"  (#7053)

* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration

* PBB migration "Pull Request Trigger" (#7054)

* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch

* PBB migration "Schedule Friday" (#7055)

* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert

* PBB migration "Move Closed Issues" (#7056)

* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js

* Add github-handle for Roland Abregorivas in heart.md #6940 (#7009)

* github-handle variable added for Gian Reyes Dionisio #6937 (#6984)

* Update contributor and language data

* updated role for Will Gillis on website project profile (#7063)

* Add github handle for Marie (#7059)

* added github handle element for Tien Yuan in heart.md (#7069)

* Update contributor and language data

* Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

* Update Roslyn's role to Developer Co-Lead (#7070)

* img Tag Refactor in Contributing.md page  (#7068)

* Update contributor and language data

* Added github-handle to Adrian Inchauste's section (#7074)

* Update contributor and language data

* edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040)

* 6786 remove bop from untaggedrepoids in get project datajs (#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <[email protected]>

* Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082)

* Update meeting data

* Update contributor and language data

* Update Inactive Members JSON

* Revert "updated-team-meeting-data-6920 (#7043)" (#7086)

This reverts commit dc11c65.

* Update contributor and language data

* Update contributor and language data

* updated team meeting data on events page to show meeting frequency

* Add 'Leadership Option' to Issue Template for CoP Information Update (#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type

* Update contributor and language data

* Updated spell checker to ignore memebers names (#7073)

* Update contributor and language data

* Update contributor and language data

* truncate contributors name in filter tag with ellipis (#7052)

* Update contributor and language data

---------

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: David Cotelessa <[email protected]>
Co-authored-by: Santiago Secco <[email protected]>
Co-authored-by: Will Gillis <[email protected]>
Co-authored-by: Jennifer Sung <[email protected]>
Co-authored-by: williamzhang <[email protected]>
Co-authored-by: Melissa McGrath <[email protected]>
Co-authored-by: Austin Labador <[email protected]>
Co-authored-by: Matthew McCane <[email protected]>
Co-authored-by: Kim <[email protected]>
Co-authored-by: Christopher Chang <[email protected]>
Co-authored-by: duojet2ez <[email protected]>
Co-authored-by: Mateo Rodriguez <[email protected]>
Co-authored-by: Danielle Andrews <[email protected]>
Co-authored-by: vanessasinam <[email protected]>
Co-authored-by: Aadil Ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-will-gillis t-will-gillis t-will-gillis approved these changes

Assignees
No one assigned
Labels
Complexity: Medium Feature: Administrative Administrative chores etc. feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the Feature: Administrative label to feature: spelling in spell check issue template
2 participants
@santisecco @t-will-gillis