-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Team Meeting Data on the Events page to Show Meeting Frequency #7043
Update Team Meeting Data on the Events page to Show Meeting Frequency #7043
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 3 PM 6/26/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @terrencejihoonjung I have a question. My knowledge in front-end is limited.
When running the website with the changes I see in the events page the addition of:
"*This meeting is not weekly, check project link for more details."
However, I see no event with the * in the end like your function does when "isWeekly":false
Could you help me understand that?
Hi @jennisung - please provide your Review ETA and Availability when you have a moment. Thanks! |
Hi @santisecco, Sure! The first thing I would do is make sure all my changes exist on your fork. This includes the modified JSON in If there's anything about changes made specifically that you want to ask about, I'm happy to explain further! |
Review ETA: By 10 PM 6/29/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Everything looks good on my end in Docker, and I see the added text at the end of the Online Project Team Meetings page. I also noticed that you updated the team meeting data to incorporate the asterisk (*) notation for non-weekly meetings per issue #6920.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terrencejihoonjung Thanks for the explanation! Yeah my question was more related to the JSON file.
Your explanation is clear, I had kind of understood what you were trying to do with insertEventSchedule
but when I visualized in docker I couldn't see the "*" added. However, today I can see it displayed.
Displayed events seem to change on a week by week basis so last week, maybe, I saw all events that were "weekly" only, so no * added, or my data was not updated. If you look at your screenshot Thursday is different, with one more *.
Still I can see that the function works now also in my end.
Great job, changes to the code are clear and accurate and you provided a clear and concise explanation of the reasons for the changes. You created the pull request with the correct branch.
Thanks for working on this and explaining!
This reverts commit dc11c65.
NOTE: opened #7086 to revert this PR |
) This reverts commit dc11c65.
) * updated-team-meeting-data-6920 * Update contributor and language data * Update contributor and language data * Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038) * Update contributor and language data * Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036) * PBB migration "Issue Trigger" (#7053) * Update issue-trigger.yml Changes in prep for Projects Beta migration * Update issue-trigger.yml space added to comment * Update issue-trigger.yml edits to comment at Team Members * Update preliminary-update-comment.js refactoring for PBB migration * PBB migration "Pull Request Trigger" (#7054) * Update pull-request-trigger.yml edits for PBB migration * Update pull-request-trigger.yml remove test branch * PBB migration "Schedule Friday" (#7055) * Update schedule-fri-0700.yml Changes for PBB migration * Update add-label.js * Update find-linked-issue.js For PBB migration * Update add-label.js remove refs to personal repo * Update add-label.js addressing CodeQL alert * Update add-label.js address CodeQL alert * PBB migration "Move Closed Issues" (#7056) * Update move-closed-issues.yaml for migration to PBB * Update sort-closed-issues.js * Add github-handle for Roland Abregorivas in heart.md #6940 (#7009) * github-handle variable added for Gian Reyes Dionisio #6937 (#6984) * Update contributor and language data * updated role for Will Gillis on website project profile (#7063) * Add github handle for Marie (#7059) * added github handle element for Tien Yuan in heart.md (#7069) * Update contributor and language data * Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque. * Update Roslyn's role to Developer Co-Lead (#7070) * img Tag Refactor in Contributing.md page (#7068) * Update contributor and language data * Added github-handle to Adrian Inchauste's section (#7074) * Update contributor and language data * edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040) * 6786 remove bop from untaggedrepoids in get project datajs (#7062) * remove references to BoP's id from the `untaggedRepoIds` list * Update contributor and language data * Revert `github.repository` post GHA test * Resolve merge conflicts * Resolve merge conflicts (p2) --------- Co-authored-by: GitHub Actions Bot <[email protected]> * Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082) * Update meeting data * Update contributor and language data * Update Inactive Members JSON * Revert "updated-team-meeting-data-6920 (#7043)" (#7086) This reverts commit dc11c65. * Update contributor and language data * Update contributor and language data * updated team meeting data on events page to show meeting frequency * Add 'Leadership Option' to Issue Template for CoP Information Update (#7077) * add leadership type option with dropdown fields * remove whitespace between labels and body * remove whitespace in title * remove whitespace in front of the yes/no options * change default type * Update contributor and language data * Updated spell checker to ignore memebers names (#7073) * Update contributor and language data * Update contributor and language data * truncate contributors name in filter tag with ellipis (#7052) * Update contributor and language data --------- Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: David Cotelessa <[email protected]> Co-authored-by: Santiago Secco <[email protected]> Co-authored-by: Will Gillis <[email protected]> Co-authored-by: Jennifer Sung <[email protected]> Co-authored-by: williamzhang <[email protected]> Co-authored-by: Melissa McGrath <[email protected]> Co-authored-by: Austin Labador <[email protected]> Co-authored-by: Matthew McCane <[email protected]> Co-authored-by: Kim <[email protected]> Co-authored-by: Christopher Chang <[email protected]> Co-authored-by: duojet2ez <[email protected]> Co-authored-by: Mateo Rodriguez <[email protected]> Co-authored-by: Danielle Andrews <[email protected]> Co-authored-by: vanessasinam <[email protected]> Co-authored-by: Aadil Ahmed <[email protected]>
Fixes #6920
What changes did you make?
vrms_data.json
to include"isWeekly": {boolean}
key-value pair based on meeting description's contentdisplay_object
function to include this property for each event objectWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
>Visuals after changes are applied