all: Downgrade to Guava 19 #2751
Conversation
Guava 20 introduced some overloading optimizations for Preconditions that require using Guava 20+ at runtime. Unfortunately, Guava 20 removes some things that is causing incompatibilities with other libraries, like Cassandra. While the incompatibility did trigger some of those libraries to improve compatibility for newer Guavas, we'd like to give the community more time to work through it. See grpc#2688 At this commit, we appear to be compatible with Guava 18+. It's not clear if we want to actually "support" 18, but it did compile. Guava 17 doesn't have at least MoreObjects, directExecutor, and firstNotNull. Guava 21 compiles without warnings, so it should be compatible with Guava 22 when it is released. One test method will fail with the upcoming Guava 22, but this won't impact applications. I made MoreThrowables to avoid using any known-deprecated Guava methods in our JARs, to reduce pain for those stuck with old versions of gRPC in the future (July 2018). In the stand-alone Android apps I removed unnecessary explicit deps instead of syncing the version used.
ejona86
added
the
TODO:backport
|
|
||
| import com.google.common.base.Preconditions; | ||
|
|
||
| /** Utility functions when interacting with {@link Throwables}. */ |
There was a problem hiding this comment.
TODO: remove this when upgrading.
| @@ -1254,7 +1254,7 @@ protected void assertRemoteAddr(String expectedRemoteAddress) { | |||
|
|
|||
| HostAndPort remoteAddress = HostAndPort.fromString(serverCallCapture.get().getAttributes() | |||
| .get(Grpc.TRANSPORT_ATTR_REMOTE_ADDR).toString()); | |||
| assertEquals(expectedRemoteAddress, remoteAddress.getHost()); | |||
| assertEquals(expectedRemoteAddress, remoteAddress.getHostText()); | |||
There was a problem hiding this comment.
This is deprecated, and will make it harder to go back up a version. Do we even need to use it?
|
This is great and will let us get on the 1.1.x branch while waiting for the cassandra and other fixes. Thank you. |
|
@carl-mastrangelo, PTAL |
|
@jhspaybar FYI this will probably not make it into 1.1.x. We plan on cutting 1.2 this week, and releasing it mid march. |
|
retest this please (for Jenkins) |
|
:'( I failed to squash first. |
|
:shame: |
|
pro tip (something that I've been doing recently): never commit something with "Address review comments" message when addressing review comments hehe, even if it's a single char change. That way, in the case of something like this, the history will look good even if PR was merged in unsquashed. Anyways, :shame: 😉 |
ejona86
removed
the
TODO:backport
Guava 20 introduced some overloading optimizations for Preconditions
that require using Guava 20+ at runtime. Unfortunately, Guava 20 removes
some things that is causing incompatibilities with other libraries, like
Cassandra. While the incompatibility did trigger some of those libraries
to improve compatibility for newer Guavas, we'd like to give the
community more time to work through it. See #2688
At this commit, we appear to be compatible with Guava 18+. It's not
clear if we want to actually "support" 18, but it did compile. Guava 17
doesn't have at least MoreObjects, directExecutor, and firstNotNull.
Guava 21 compiles without warnings, so it should be compatible with
Guava 22 when it is released.
One test method will fail with the upcoming Guava 22, but this won't
impact applications. I made MoreThrowables to avoid using any
known-deprecated Guava methods in our JARs, to reduce pain for those
stuck with old versions of gRPC in the future (July 2018).
In the stand-alone Android apps I removed unnecessary explicit deps
instead of syncing the version used.