Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Guava 20 #4176

Closed
ejona86 opened this issue Mar 6, 2018 · 2 comments
Closed

Bump to Guava 20 #4176

ejona86 opened this issue Mar 6, 2018 · 2 comments
Assignees
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented Mar 6, 2018

We downgraded to Guava 19 in #2751. A lot of time has passed. We really want to get on to the more stable Guava versions.

We want to bump to Guava 20, and if that goes well try to bump further. I think Guava 21 was built with JDK 8 (or some such), so we need to avoid, but the following fixed that.

After we get to Guava 20 we should open a new issue to track upgrading further.

@ejona86 ejona86 added this to the Next milestone Mar 6, 2018
@ejona86 ejona86 self-assigned this Mar 6, 2018
@rmichela
Copy link
Contributor

rmichela commented Mar 7, 2018

Does gRPC use any Guava APIs that have been deprecated or removed in Guava 21+?

Many of our internal utility libraries depend on Java 8 and use the Java 8 features of Guava 21+. The Guava 19/20+ incompatibility problems have forced us to do uncomfortable things with shading and relocating.

With this change, will gRPC be forward compatible with the latest version of Guava, in case a consumer has to pull a more recent version onto the classpath?

@ejona86
Copy link
Member Author

ejona86 commented Mar 7, 2018

@rmichela, gRPC Java works fine with newer releases of Guava. There's no deprecation warnings when building grpc-java with Guava 24.0-android or 24.0-jre. This is very important to us and will continue to be maintained.

I'll note that gRPC won't upgrade to Guava 21 as it is slightly special, and was built with Java 8. Once we drop Java 6 support we could upgrade to an "android" version starting with Guava 22 which is built with Java 7.

ejona86 added a commit to ejona86/grpc-java that referenced this issue Mar 23, 2018
ejona86 added a commit that referenced this issue Mar 23, 2018
ejona86 added a commit to ejona86/grpc-java that referenced this issue Mar 23, 2018
@ejona86 ejona86 modified the milestones: Next, 1.11 Mar 23, 2018
ejona86 added a commit that referenced this issue Mar 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants